Devuan logs - #176, boring messages

Message sent to [email protected], [email protected]:

Subject: bug#176: vde2: ifup plugin-stanza "vde2-plug" does not capture correct PID
Reply-To: Guenther Brunthaler <[email protected]>, [email protected]
Resent-From: Guenther Brunthaler <[email protected]>
Resent-To: [email protected]
Resent-CC: [email protected]
Resent-Date: Sat, 20 Jan 2018 07:03:01 UTC
Resent-Message-ID: <[email protected]>
Resent-Sender: [email protected]
From: Guenther Brunthaler <[email protected]>
To: Devuan Bug Tracking System <[email protected]>
Message-ID: <[email protected]>
Date: Sat, 20 Jan 2018 07:43:10 +0100
User-Agent: Mozilla/5.0 (X11; Linux i686 on x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.5.2
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-15; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit

Package: vde2
Version: 2.3.2+r586-1
Severity: normal
X-Debbugs-Cc: [email protected]

Dear Maintainer,

Preliminary remark: Even though I am using Devuan rather then Debian, I
have verified that the problem still exists in the current "stretch"
version (vde2_2.3.2+r586-2.1_amd64.deb) of the package.

"ifup" for a virtual VDE2 tun/tap plug records an incorrect PID for the
vde_plug2tap process in the pidfile, and "ifdown" will therefore not be
able to shut it down.

As a consequence, the vde_plug2tap process keeps running, wasting
resources, and the tun/tap interface remains still visible with
ifconfig -a, even though it will have been deconfigured.

The problem arises when using ifup/ifdown to configure additional
tun/tap interfaces for a VDE2 switch.

Such additional network interfaces are necessary when binding normal
applications running on the local box (and not in VM guests) to
different VLANs managed by the same virtual VDE2 switch.

For instance, when adding the following /etc/network/interfaces entry

iface ethsmb inet static
         vde2-plug vde_plug2tap -p 5 -s /var/run/vde2/ethvm.ctl ethsmb
         address 10.35.43.113
         netmask 255.255.0.0

then "ifup ethsmb" makes a new network interface "ethsmb" appear which 
is connected to port 5 on the virtual switch (which itself manages 
another network interface "ethvm").

"ifdown ethsmb" should make the new interface go away, but it won't.

The problem is located in plug-in script /etc/network/if-pre-up.d/vde2
from the package.

This script contains a command

start-stop-daemon --start --quiet --pidfile $PIDFILE \
--make-pidfile --background \
--exec $DPIPE -- $VDE_PLUG -g $GROUP -m 660 $CTLDIR = "$@"

It seems dpipe double-forks under certain situations, at least in this
case, and so the --background option of start-stop-daemon has no effect
and the --pidfile captures the wrong PID.

This can also be verified by just running the resulting dpipe command
manually without the "start-stop-daemon": It returns immediately,
obviously forking the processes into the background, and $! does *not*
contain a valid process ID.

I have also figured out what needs to be changed in order to make 
everything work as intended again: Just exchange the order of commands 
connected with dpipe. In other words, change the

    --exec $DPIPE -- $VDE_PLUG -g $GROUP -m 660 $CTLDIR = "$@"

line into

    --exec $DPIPE -- "$@" = $VDE_PLUG -g $GROUP -m 660 $CTLDIR

It turns out that the order of commands in dpipe is not irrelevant if 
the processes have different lifetimes.

In such a case, the first command must be that with the longer lifetime, 
because dpipe will exec itself into that command, and its PID will be 
used by the caller of dpipe in order to terminate the pipeline later.

-- System Information:
Distributor ID:	Devuan
Description:	Devuan GNU/Linux 1.0 (jessie)
Release:	1.0
Codename:	jessie
Architecture: x86_64

Kernel: Linux 3.16.0-4-amd64 (SMP w/4 CPU cores)
Locale: LANG=de_AT.UTF-8, LC_CTYPE=de_AT.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: sysvinit (via /sbin/init)

Versions of packages vde2 depends on:
ii  adduser      3.113+nmu3
ii  libc6        2.19-18+deb8u10
ii  libpcap0.8   1.6.2-2
ii  libvde0      2.3.2+r586-1
ii  libvdeplug2  2.3.2+r586-1

vde2 recommends no packages.

Versions of packages vde2 suggests:
pn  qemu           <none>
ii  qemu-kvm       1:2.1+dfsg-12+deb8u6
ii  vde2-cryptcab  2.3.2+r586-1

-- no debconf information

Message sent:

X-Loop: [email protected]
From: [email protected] (Devuan bug Tracking System)
To: Guenther Brunthaler <[email protected]>
Subject: bug#176: Acknowledgement (vde2: ifup plugin-stanza "vde2-plug" does not capture correct PID)
Message-ID: <[email protected]>
In-Reply-To: <[email protected]>
References: <[email protected]>
Precedence: bulk
X-Devuan-PR-Message: ack 176
X-Devuan-PR-Package: vde2
X-Devuan-PR-Keywords: 
Reply-To: [email protected]

Thank you for the problem report you have sent regarding Devuan.
This is an automatically generated reply, to let you know your message has
been received.  It is being forwarded to the developers mailing list for
their attention; they will reply in due course.

Your message has been sent to the package maintainer(s):
 [email protected]

If you wish to submit further information on your problem, please send
it to [email protected] (and *not* to
[email protected]).

Please do not reply to the address at the top of this message,
unless you wish to report a problem with the bug-tracking system.

Devuan Bugs Owner
(administrator, Devuan bugs database)

Message received at [email protected]:

To: [email protected]
From: OmegaPhil <[email protected]>
Message-ID: <[email protected]>
Date: Sun, 18 Feb 2018 19:34:39 +0000
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Language: en-GB
Content-Transfer-Encoding: 8bit

tags 14 ascii
tags 157 ceres
tags 178 jessie
tags 129 jessie ascii
tags 184 ascii
tags 174 ascii
tags 172 ascii
tags 171 jessie ascii
tags 170 jessie
tags 116 experimental
tags 177 ascii
tags 42 ascii
tags 181 ascii
tags 161 jessie
tags 180 ascii
tags 176 jessie
tags 76 jessie ascii
tags 173 ascii
tags 179 ceres
tags 182 ascii
tags 56 jessie

Message sent to [email protected], [email protected]:

Subject: bug#176: vde2: ifup plugin-stanza "vde2-plug" does not capture correct PID
Reply-To: Mark Hindley <[email protected]>, [email protected]
Resent-From: Mark Hindley <[email protected]>
Resent-To: [email protected]
Resent-CC: [email protected]
Resent-Date: Tue, 10 Jan 2023 18:50:01 +0000
Resent-Message-ID: <[email protected]>
Resent-Sender: [email protected]
References: <[email protected]> <[email protected]>
Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=193.36.131.86; helo=mx.hindley.org.uk; [email protected]; receiver=<UNKNOWN> 
Date: Tue, 10 Jan 2023 18:47:16 +0000
From: Mark Hindley <[email protected]>
To: Guenther Brunthaler <[email protected]>, [email protected]
Message-ID: <[email protected]>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <[email protected]>

Control: tags -1 moreinfo debian

This appears unchanged in the Debian sources. Is it still an issue? If so,
please report to Debian BTS as it is not a forked package.

Thanks

Mark

Message received at [email protected]:

Received: (at 176) by bugs.devuan.org; 10 Jan 2023 18:48:10 +0000
Return-Path: <[email protected]>
Delivered-To: [email protected]
Received: from email.devuan.org [2001:41d0:2:d06e::5c4:2612]
	by doc.devuan.org with IMAP (fetchmail-6.4.16)
	for <debbugs@localhost> (single-drop); Tue, 10 Jan 2023 18:48:10 +0000 (UTC)
Received: from email.devuan.org
	by email.devuan.org with LMTP
	id 3HsvEbayvWNpMQAAmSBk0A
	(envelope-from <[email protected]>)
	for <[email protected]>; Tue, 10 Jan 2023 18:47:18 +0000
Received: by email.devuan.org (Postfix, from userid 109)
	id 373E7B85; Tue, 10 Jan 2023 18:47:18 +0000 (UTC)
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on email.devuan.org
X-Spam-Level: 
X-Spam-Status: No, score=0.4 required=5.0 tests=RDNS_DYNAMIC,SPF_PASS
	autolearn=no autolearn_force=no version=3.4.6
Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=193.36.131.86; helo=mx.hindley.org.uk; [email protected]; receiver=<UNKNOWN> 
Received: from mx.hindley.org.uk (193-36-131-86.cfwn.uk [193.36.131.86])
	by email.devuan.org (Postfix) with ESMTPS id B729D2A8
	for <[email protected]>; Tue, 10 Jan 2023 18:47:17 +0000 (UTC)
Received: from apollo.hindleynet ([192.168.1.3] helo=hindley.org.uk)
	by mx.hindley.org.uk with smtp (Exim 4.84_2)
	(envelope-from <[email protected]>)
	id 1pFJeW-0003lP-7Q; Tue, 10 Jan 2023 18:47:16 +0000
Received: (nullmailer pid 21915 invoked by uid 1000);
	Tue, 10 Jan 2023 18:47:16 -0000
Date: Tue, 10 Jan 2023 18:47:16 +0000
From: Mark Hindley <[email protected]>
To: Guenther Brunthaler <[email protected]>, [email protected]
Subject: Re: bug#176: vde2: ifup plugin-stanza "vde2-plug" does not capture
 correct PID
Message-ID: <[email protected]>
References: <[email protected]>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <[email protected]>
X-Debbugs-No-Ack: No Thanks

Control: tags -1 moreinfo debian

This appears unchanged in the Debian sources. Is it still an issue? If so,
please report to Debian BTS as it is not a forked package.

Thanks

Mark

Message sent to [email protected], [email protected]:

X-Loop: [email protected]
Subject: bug#176: vde2: ifup plugin-stanza "vde2-plug" does not capture correct PID
Reply-To: Mark Hindley <[email protected]>, [email protected]
Resent-From: Mark Hindley <[email protected]>
Resent-To: [email protected]
Resent-CC: [email protected]
X-Loop: [email protected]
Resent-Date: Fri, 10 Feb 2023 10:08:02 +0000
Resent-Message-ID: <[email protected]>
Resent-Sender: [email protected]
X-Devuan-PR-Message: followup 176
X-Devuan-PR-Package: vde2
X-Devuan-PR-Keywords: jessie debian moreinfo
References: <[email protected]> <[email protected]> <[email protected]> <[email protected]>
Received: via spool by [email protected] id=B176.167602366724825
          (code B ref 176); Fri, 10 Feb 2023 10:08:02 +0000
Received: (at 176) by bugs.devuan.org; 10 Feb 2023 10:07:47 +0000
Delivered-To: [email protected]
Received: from email.devuan.org [2001:41d0:2:d06e::5c4:2612]
	by doc.devuan.org with IMAP (fetchmail-6.4.16)
	for <debbugs@localhost> (single-drop); Fri, 10 Feb 2023 10:07:47 +0000 (UTC)
Received: from email.devuan.org
	by email.devuan.org with LMTP
	id RKQlOykX5mPMBQAAmSBk0A
	(envelope-from <[email protected]>)
	for <[email protected]>; Fri, 10 Feb 2023 10:06:33 +0000
Received: by email.devuan.org (Postfix, from userid 109)
	id E6495B10; Fri, 10 Feb 2023 10:06:33 +0000 (UTC)
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on email.devuan.org
X-Spam-Level: 
X-Spam-Status: No, score=0.4 required=5.0 tests=RDNS_DYNAMIC,SPF_PASS
	autolearn=no autolearn_force=no version=3.4.6
Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=193.36.131.86; helo=mx.hindley.org.uk; [email protected]; receiver=<UNKNOWN> 
Received: from mx.hindley.org.uk (193-36-131-86.cfwn.uk [193.36.131.86])
	by email.devuan.org (Postfix) with ESMTPS id E5F7884
	for <[email protected]>; Fri, 10 Feb 2023 10:06:28 +0000 (UTC)
Received: from apollo.hindleynet ([192.168.1.3] helo=hindley.org.uk)
	by mx.hindley.org.uk with smtp (Exim 4.84_2)
	(envelope-from <[email protected]>)
	id 1pQQIV-0002nR-7j; Fri, 10 Feb 2023 10:06:27 +0000
Received: (nullmailer pid 32435 invoked by uid 1000);
	Fri, 10 Feb 2023 10:06:27 -0000
Date: Fri, 10 Feb 2023 10:06:27 +0000
From: Mark Hindley <[email protected]>
To: [email protected]
Cc: Guenther Brunthaler <[email protected]>
Message-ID: <[email protected]>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <[email protected]>

Control: forwarded -1 https://bugs.debian.org/1031003
Control: tags -1 - moreinfo

Forwarded to Debian BTS on your behalf.

Mark

Message received at [email protected]:

Received: (at 176) by bugs.devuan.org; 10 Feb 2023 10:07:47 +0000
Return-Path: <[email protected]>
Delivered-To: [email protected]
Received: from email.devuan.org [2001:41d0:2:d06e::5c4:2612]
	by doc.devuan.org with IMAP (fetchmail-6.4.16)
	for <debbugs@localhost> (single-drop); Fri, 10 Feb 2023 10:07:47 +0000 (UTC)
Received: from email.devuan.org
	by email.devuan.org with LMTP
	id RKQlOykX5mPMBQAAmSBk0A
	(envelope-from <[email protected]>)
	for <[email protected]>; Fri, 10 Feb 2023 10:06:33 +0000
Received: by email.devuan.org (Postfix, from userid 109)
	id E6495B10; Fri, 10 Feb 2023 10:06:33 +0000 (UTC)
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on email.devuan.org
X-Spam-Level: 
X-Spam-Status: No, score=0.4 required=5.0 tests=RDNS_DYNAMIC,SPF_PASS
	autolearn=no autolearn_force=no version=3.4.6
Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=193.36.131.86; helo=mx.hindley.org.uk; [email protected]; receiver=<UNKNOWN> 
Received: from mx.hindley.org.uk (193-36-131-86.cfwn.uk [193.36.131.86])
	by email.devuan.org (Postfix) with ESMTPS id E5F7884
	for <[email protected]>; Fri, 10 Feb 2023 10:06:28 +0000 (UTC)
Received: from apollo.hindleynet ([192.168.1.3] helo=hindley.org.uk)
	by mx.hindley.org.uk with smtp (Exim 4.84_2)
	(envelope-from <[email protected]>)
	id 1pQQIV-0002nR-7j; Fri, 10 Feb 2023 10:06:27 +0000
Received: (nullmailer pid 32435 invoked by uid 1000);
	Fri, 10 Feb 2023 10:06:27 -0000
Date: Fri, 10 Feb 2023 10:06:27 +0000
From: Mark Hindley <[email protected]>
To: [email protected]
Cc: Guenther Brunthaler <[email protected]>
Subject: Re: bug#176: vde2: ifup plugin-stanza "vde2-plug" does not capture
 correct PID
Message-ID: <[email protected]>
References: <[email protected]>
 <[email protected]>
 <[email protected]>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <[email protected]>
X-Debbugs-No-Ack: No Thanks

Control: forwarded -1 https://bugs.debian.org/1031003
Control: tags -1 - moreinfo

Forwarded to Debian BTS on your behalf.

Mark

Message received at [email protected]:

Received: (at 176) by bugs.devuan.org; 10 Feb 2023 10:07:47 +0000
Return-Path: <[email protected]>
Delivered-To: [email protected]
Received: from email.devuan.org [2001:41d0:2:d06e::5c4:2612]
	by doc.devuan.org with IMAP (fetchmail-6.4.16)
	for <debbugs@localhost> (single-drop); Fri, 10 Feb 2023 10:07:47 +0000 (UTC)
Received: from email.devuan.org
	by email.devuan.org with LMTP
	id RKQlOykX5mPMBQAAmSBk0A
	(envelope-from <[email protected]>)
	for <[email protected]>; Fri, 10 Feb 2023 10:06:33 +0000
Received: by email.devuan.org (Postfix, from userid 109)
	id E6495B10; Fri, 10 Feb 2023 10:06:33 +0000 (UTC)
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on email.devuan.org
X-Spam-Level: 
X-Spam-Status: No, score=0.4 required=5.0 tests=RDNS_DYNAMIC,SPF_PASS
	autolearn=no autolearn_force=no version=3.4.6
Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=193.36.131.86; helo=mx.hindley.org.uk; [email protected]; receiver=<UNKNOWN> 
Received: from mx.hindley.org.uk (193-36-131-86.cfwn.uk [193.36.131.86])
	by email.devuan.org (Postfix) with ESMTPS id E5F7884
	for <[email protected]>; Fri, 10 Feb 2023 10:06:28 +0000 (UTC)
Received: from apollo.hindleynet ([192.168.1.3] helo=hindley.org.uk)
	by mx.hindley.org.uk with smtp (Exim 4.84_2)
	(envelope-from <[email protected]>)
	id 1pQQIV-0002nR-7j; Fri, 10 Feb 2023 10:06:27 +0000
Received: (nullmailer pid 32435 invoked by uid 1000);
	Fri, 10 Feb 2023 10:06:27 -0000
Date: Fri, 10 Feb 2023 10:06:27 +0000
From: Mark Hindley <[email protected]>
To: [email protected]
Cc: Guenther Brunthaler <[email protected]>
Subject: Re: bug#176: vde2: ifup plugin-stanza "vde2-plug" does not capture
 correct PID
Message-ID: <[email protected]>
References: <[email protected]>
 <[email protected]>
 <[email protected]>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <[email protected]>
X-Debbugs-No-Ack: No Thanks

Control: forwarded -1 https://bugs.debian.org/1031003
Control: tags -1 - moreinfo

Forwarded to Debian BTS on your behalf.

Mark