X-Loop: [email protected] Subject: bug#309: remove flag "-f" in pidof Reply-To: KatolaZ <[email protected]>, [email protected] Resent-From: KatolaZ <[email protected]> Resent-To: [email protected] Resent-CC: [email protected] Resent-Date: Tue, 19 Mar 2019 06:33:01 UTC Resent-Message-ID: <[email protected]> Resent-Sender: [email protected] X-Devuan-PR-Message: report 309 X-Devuan-PR-Package: sysvinit-utils X-Devuan-PR-Keywords: Received: via spool by [email protected] id=B.155297700423092 (code B ref -1); Tue, 19 Mar 2019 06:33:01 UTC Received: (at submit) by bugs.devuan.org; 19 Mar 2019 06:30:04 +0000 Delivered-To: [email protected] Received: from tupac3.dyne.org [195.169.149.119] by fulcanelli with IMAP (fetchmail-6.3.26) for <debbugs@localhost> (single-drop); Tue, 19 Mar 2019 07:30:04 +0100 (CET) Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: [email protected]) with ESMTPSA id C36DDF60BD2 Date: Tue, 19 Mar 2019 07:29:11 +0100 From: KatolaZ <[email protected]> To: [email protected] Message-ID: <[email protected]> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="5uvpalol52xldhbj" Content-Disposition: inline User-Agent: NeoMutt/20170113 (1.7.2) X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED autolearn=disabled version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on tupac3.dyne.org --5uvpalol52xldhbj Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Package: sysvinit-utils Version: 2.93-8 Severity: normal I am opening this bug because I think the recently added flag '-f' in pidof should be removed. It was intended to be used as a way to format the PIDs according to printf-style formatters, but accepting unsanitised input from the user is quite dangerous, as shown in #924792. The proposed solution to #924792 was to let pidof -f interpret only '%d' and '\n'. This is at least an unnecessary complication. pidof is already printing the PIDs as integers (!), and any formatting can (but I would say should/must) be done downstream by sed/awk/whatever. We can't add a formatter to any single CLI command :\ Please remove the unneded '-f' flag. Unix is much much better than that. KatolaZ --5uvpalol52xldhbj Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABECAB0WIQSOWdaqRF79tKFTPVpfILOuC18GLwUCXJCMNAAKCRBfILOuC18G L6dKAJ9KOs2IoM71/3Ia4TuTxHxIaaPcyACfUhYw68q9RBRq+AsVnzwyqF2ir24= =vgYs -----END PGP SIGNATURE----- --5uvpalol52xldhbj--
X-Loop: [email protected] From: [email protected] (Devuan bug Tracking System) To: KatolaZ <[email protected]> Subject: bug#309: Acknowledgement (remove flag "-f" in pidof) Message-ID: <[email protected]> In-Reply-To: <[email protected]> References: <[email protected]> Precedence: bulk X-Devuan-PR-Message: ack 309 X-Devuan-PR-Package: sysvinit-utils X-Devuan-PR-Keywords: Reply-To: [email protected] Thank you for the problem report you have sent regarding Devuan. This is an automatically generated reply, to let you know your message has been received. It is being forwarded to the developers mailing list for their attention; they will reply in due course. Your message has been sent to the package maintainer(s): [email protected] If you wish to submit further information on your problem, please send it to [email protected] (and *not* to [email protected]). Please do not reply to the address at the top of this message, unless you wish to report a problem with the bug-tracking system. Devuan Bugs Owner (administrator, Devuan bugs database)
X-Loop: [email protected] From: [email protected] (Devuan bug Tracking System) To: KatolaZ <[email protected]> Cc: [email protected] Subject: bug#309: marked as done (remove flag "-f" in pidof) Message-ID: <[email protected]> In-Reply-To: <[email protected]> References: <[email protected]> <[email protected]> Precedence: bulk X-Devuan-PR-Message: closed 309 X-Devuan-PR-Package: sysvinit-utils X-Devuan-PR-Keywords: Your message dated Tue, 19 Mar 2019 07:39:19 +0100 with message-id <[email protected]> and subject line sorry, wrong BTS has caused the attached bug report to be marked as done. This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what I am talking about this indicates a serious mail system misconfiguration somewhere. Please contact me immediately.) Devuan Bugs Owner (administrator, Devuan bugs database) -------------------------------------- Received: (at submit) by bugs.devuan.org; 19 Mar 2019 06:30:04 +0000 Return-Path: <[email protected]> Delivered-To: [email protected] Received: from tupac3.dyne.org [195.169.149.119] by fulcanelli with IMAP (fetchmail-6.3.26) for <debbugs@localhost> (single-drop); Tue, 19 Mar 2019 07:30:04 +0100 (CET) Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: [email protected]) with ESMTPSA id C36DDF60BD2 Date: Tue, 19 Mar 2019 07:29:11 +0100 From: KatolaZ <[email protected]> To: [email protected] Subject: remove flag "-f" in pidof Message-ID: <[email protected]> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="5uvpalol52xldhbj" Content-Disposition: inline User-Agent: NeoMutt/20170113 (1.7.2) X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED autolearn=disabled version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on tupac3.dyne.org --5uvpalol52xldhbj Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Package: sysvinit-utils Version: 2.93-8 Severity: normal I am opening this bug because I think the recently added flag '-f' in pidof should be removed. It was intended to be used as a way to format the PIDs according to printf-style formatters, but accepting unsanitised input from the user is quite dangerous, as shown in #924792. The proposed solution to #924792 was to let pidof -f interpret only '%d' and '\n'. This is at least an unnecessary complication. pidof is already printing the PIDs as integers (!), and any formatting can (but I would say should/must) be done downstream by sed/awk/whatever. We can't add a formatter to any single CLI command :\ Please remove the unneded '-f' flag. Unix is much much better than that. KatolaZ --5uvpalol52xldhbj Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABECAB0WIQSOWdaqRF79tKFTPVpfILOuC18GLwUCXJCMNAAKCRBfILOuC18G L6dKAJ9KOs2IoM71/3Ia4TuTxHxIaaPcyACfUhYw68q9RBRq+AsVnzwyqF2ir24= =vgYs -----END PGP SIGNATURE----- --5uvpalol52xldhbj-- --------------------------------------- Received: (at 309-done) by bugs.devuan.org; 19 Mar 2019 06:40:05 +0000 Return-Path: <[email protected]> Delivered-To: [email protected] Received: from tupac3.dyne.org [195.169.149.119] by fulcanelli with IMAP (fetchmail-6.3.26) for <debbugs@localhost> (single-drop); Tue, 19 Mar 2019 07:40:05 +0100 (CET) Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: [email protected]) with ESMTPSA id 65F76F6088C Date: Tue, 19 Mar 2019 07:39:19 +0100 From: KatolaZ <[email protected]> To: [email protected] Subject: sorry, wrong BTS Message-ID: <[email protected]> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="tuzy4pp6moump64x" Content-Disposition: inline User-Agent: NeoMutt/20170113 (1.7.2) X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED autolearn=disabled version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on tupac3.dyne.org --tuzy4pp6moump64x Content-Type: text/plain; charset=us-ascii Content-Disposition: inline This should have gone to bugs.debian.org. Sorry. Closing KatolaZ --tuzy4pp6moump64x Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABECAB0WIQSOWdaqRF79tKFTPVpfILOuC18GLwUCXJCOlwAKCRBfILOuC18G L2WYAJ0Vw/iufuvG4aGNcn+IktkDD7ZaYACcCLmv/ZVaS4j9P1OKTW3rsC06t7Q= =Rlrf -----END PGP SIGNATURE----- --tuzy4pp6moump64x--
X-Loop: [email protected] From: [email protected] (Devuan bug Tracking System) To: KatolaZ <[email protected]> Subject: bug#309 acknowledged by developer (sorry, wrong BTS) Message-ID: <[email protected]> In-Reply-To: <[email protected]> References: <[email protected]> <[email protected]> X-Devuan-PR-Message: they-closed 309 X-Devuan-PR-Package: sysvinit-utils X-Devuan-PR-Keywords: Reply-To: [email protected] This is an automatic notification regarding your bug report #309: remove flag "-f" in pidof, which was filed against the sysvinit-utils package. It has been closed by one of the developers, namely KatolaZ <[email protected]>. Their explanation is attached below. If this explanation is unsatisfactory and you have not received a better one in a separate message then please contact the developer, by replying to this email. Devuan Bugs Owner (administrator, Devuan bugs database) Received: (at 309-done) by bugs.devuan.org; 19 Mar 2019 06:40:05 +0000 Return-Path: <[email protected]> Delivered-To: [email protected] Received: from tupac3.dyne.org [195.169.149.119] by fulcanelli with IMAP (fetchmail-6.3.26) for <debbugs@localhost> (single-drop); Tue, 19 Mar 2019 07:40:05 +0100 (CET) Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: [email protected]) with ESMTPSA id 65F76F6088C Date: Tue, 19 Mar 2019 07:39:19 +0100 From: KatolaZ <[email protected]> To: [email protected] Subject: sorry, wrong BTS Message-ID: <[email protected]> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="tuzy4pp6moump64x" Content-Disposition: inline User-Agent: NeoMutt/20170113 (1.7.2) X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED autolearn=disabled version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on tupac3.dyne.org --tuzy4pp6moump64x Content-Type: text/plain; charset=us-ascii Content-Disposition: inline This should have gone to bugs.debian.org. Sorry. Closing KatolaZ --tuzy4pp6moump64x Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABECAB0WIQSOWdaqRF79tKFTPVpfILOuC18GLwUCXJCOlwAKCRBfILOuC18G L2WYAJ0Vw/iufuvG4aGNcn+IktkDD7ZaYACcCLmv/ZVaS4j9P1OKTW3rsC06t7Q= =Rlrf -----END PGP SIGNATURE----- --tuzy4pp6moump64x--
Devuan BTS -- Powered by Debian bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997 nCipher Corporation Ltd,
1994-97 Ian Jackson.
Devuan Bugs Owner <[email protected]>.
Last modified:
Sat, 18 Jan 2025 06:39:02 UTC