Devuan bug report logs - #392
When pid1==runit, mis-detects container and doesn't start

Package: eudev; Reported by: KORN Andras <[email protected]>; Done: Svante Signell <[email protected]>; Maintainer for eudev is Devuan Dev Team <[email protected]>.

Message received at [email protected]:

Message-ID: <[email protected]>
Subject: [Devuan-bugs] bug#392: When pid1==runit, mis-detects container and
 doesn't start
From: Svante Signell <[email protected]>
Reply-To: [email protected]
To: [email protected]
Date: Mon, 24 Feb 2020 11:15:59 +0100
Content-Type: text/plain
User-Agent: Evolution 3.30.5-1 
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable

Fixed by eudev-3.2.9-6, closing.

Notification sent to KORN Andras <[email protected]>:
bug acknowledged by developer. Full text available.

Reply sent to [email protected]:
You have taken responsibility. Full text available.

Message received at [email protected]:

Date: Mon, 10 Feb 2020 15:36:13 +0100
From: KORN Andras <[email protected]>
To: [email protected]
Subject: Re: When pid1==runit, mis-detects container and doesn't start
Message-ID: <20200210143613.nflqmqpsrwrmljs5@hellgate>
References: <20200209103448.lancgj764wum4y4x@hellgate>
 <[email protected]>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <[email protected]>

Hi,

> So the name of pid 1 for runit-init is runit?
> Then the test could be
> -q "init\|runit\|systemd"
> 
> What about other init systems, like openrc-init? Perhaps the test should be
> reversed if ps -p1 | -q "container tests here" instead.

runit is a perfectly viable init system for a container, so detecting that
pid1==runit gives no clue whether you're inside a container or not.

> > Perhaps use virt-what to detect containers instead?
>
> I've been looking for methods to detect containers, but have not found virt-
> what. Do you have a link or a description?

Sure:

Package: virt-what
Status: install ok installed
Priority: extra
Section: admin
Installed-Size: 48
Maintainer: Debian Libvirt Maintainers <[email protected]>
Architecture: amd64
Version: 1.19-1
Depends: dmidecode, libc6 (>= 2.4)
Description: detect if we are running in a virtual machine
 Virt-what is a shell script which can be used to detect if the program is
 running in a virtual machine (VM).
 .
 The program prints out a list of "facts" about the virtual machine, derived
 from heuristics. One fact is printed per line.
Description-md5: 5d47386fbabb50c244e6526dada61a44
Homepage: https://people.redhat.com/~rjones/virt-what/

% apt-cache policy virt-what                                                                                                                                                                                                                                                         =79%
virt-what:
  Installed: 1.19-1
  Candidate: 1.19-1
  Version table:
 *** 1.19-1 500
        500 http://packages.devuan.org/merged unstable/main amd64 Packages
        100 /var/lib/dpkg/status
     1.15-1+deb9u1 500
        500 http://packages.devuan.org/merged ascii/main amd64 Packages

Note that while virt-what detects lxc, it doesn't currently correctly detect
all versions of linux-vserver.

Best regards,

András

Ps. I only found your reply by accident. I'm not subscribed do the Devuan
mailing lists and bugs.devuan.org doesn't seem to have Cc'd me. Please Cc me
explicitly.

-- 
  Illegal copies are not theft. Theft removes the original; a copy is a copy.

Acknowledgement sent to KORN Andras <[email protected]>:
Extra info received and forwarded to list. Copy sent to Devuan Dev Team <[email protected]>. Full text available.

Information forwarded to [email protected], Devuan Dev Team <[email protected]>:
bug#392; Package eudev. Full text available.

Message received at [email protected]:

Received: (at 392) by bugs.devuan.org; 10 Feb 2020 09:17:49 +0000
Return-Path: <[email protected]>
Delivered-To: [email protected]
Received: from tupac3.dyne.org [195.169.149.119]
	by doc.devuan.org with IMAP (fetchmail-6.4.0.beta4)
	for <debbugs@localhost> (single-drop); Mon, 10 Feb 2020 09:17:49 +0000 (UTC)
Received: from mail-lf1-f54.google.com (mail-lf1-f54.google.com [209.85.167.54])
	(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
	(No client certificate requested)
	by vm6.ganeti.dyne.org (Postfix) with ESMTPS id 7FABEF6094A
	for <[email protected]>; Mon, 10 Feb 2020 10:16:25 +0100 (CET)
Authentication-Results: vm6.ganeti.dyne.org;
	dkim=pass (2048-bit key; unprotected) header.d=gmail.com [email protected] header.b="QQqui9/Y";
	dkim-atps=neutral
Received: by mail-lf1-f54.google.com with SMTP id 203so3610595lfa.12
        for <[email protected]>; Mon, 10 Feb 2020 01:16:25 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20161025;
        h=message-id:subject:from:reply-to:to:date:in-reply-to:references
         :organization:user-agent:mime-version:content-transfer-encoding;
        bh=vpkUC0C4INK5Mh4MOXOOc73L+LbV6TL6ZINWx1+fTyA=;
        b=QQqui9/YHl8FCnRVkd/5dsfD0rm2/1zCjmEkINiTwt+5d/MBBR6gd9nJtj24xZxdn7
         hz1if2WKV02V/nthYqS1vibuPZYKRB0SumcrcuO1bsT+fqZD5+XidbPBCcNwexOzgUcP
         CRL2UxqwXrTc31jY1Y5LN2RnifGw8EdKOTC/NctzwJvGE/NL3rJa+X7El55kxdrtx67r
         9+A67IkANpRBPBgp1RInprv+IReDZCsZek18PZWT9drSG4GdnfUOP1Vcqaxm0oib+HMb
         0b2w805Qd0S9Eb5agESilleYZfy2zeBWCmqc1hacyM5JWUVRRwee875un4bFXElB6m2Q
         Mlaw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20161025;
        h=x-gm-message-state:message-id:subject:from:reply-to:to:date
         :in-reply-to:references:organization:user-agent:mime-version
         :content-transfer-encoding;
        bh=vpkUC0C4INK5Mh4MOXOOc73L+LbV6TL6ZINWx1+fTyA=;
        b=kJiDiyvKGzw5yUyxS/T8uqhrJEW/novCSrfEfgBHNsBdGs2Bwi5UN4Tbl6HdnBol4K
         qYCP2GWTEhjz3tMnfKg1t8b60vkjZCAeDwQFr3Zfv5HS1VbGSn6e4bPhyoS5QuZLBgFU
         CpRr2rTtKN5l9a0vaZyv1wdLSM4hIluYlHmuUs3XMXy3GroBk7prgrTFFZKlyp2T1oUL
         LiXdhiLyudMjDeqJJMPV0LCerqe6Rd1mlf5VbPYz0dt5Yx26mdn4Ar5BDW0TdRQMrUlH
         ERTtwa/Qt6yEEL9EZtVRPbqYwbp/HsNSEN4fmgm+9GjERpwMh205ooE0uQdusmuUmfn0
         /YMQ==
X-Gm-Message-State: APjAAAXFip0UpDqlaGBeNkIfPxPzrfOdb5niSKF1qF7eNB6WpP3gJlZ+
	i+yfgZLUmmtTlxDc08tlYFrBLUWc
X-Google-Smtp-Source: APXvYqwiv2a13sPzJuc35trV0rX5JfiOlOFg+b0UT57kXH5w/3TACu0zEf32lEo/HZ0h1Qnxma61MQ==
X-Received: by 2002:a19:5f5e:: with SMTP id a30mr235790lfj.183.1581326183051;
        Mon, 10 Feb 2020 01:16:23 -0800 (PST)
Received: from G3620.lan (178-78-231-178.customers.ownit.se. [178.78.231.178])
        by smtp.gmail.com with ESMTPSA id l12sm5959146lji.52.2020.02.10.01.16.22
        (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
        Mon, 10 Feb 2020 01:16:22 -0800 (PST)
Message-ID: <[email protected]>
Subject: Re: [devuan-dev] bug#392: When pid1==runit, mis-detects container
 and doesn't start
From: Svante Signell <[email protected]>
Reply-To: [email protected]
To: [email protected]
Date: Mon, 10 Feb 2020 10:17:41 +0100
In-Reply-To: <20200209103448.lancgj764wum4y4x@hellgate>
References: <20200209103448.lancgj764wum4y4x@hellgate>
Organization: Home
Content-Type: text/plain; charset="ISO-8859-1"
User-Agent: Evolution 3.30.5-1.1 
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
X-Spam-Status: No, score=-0.2 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_PASS
	autolearn=disabled version=3.4.2
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on tupac3.dyne.org

On Sun, 2020-02-09 at 11:34 +0100, KORN Andras wrote:
> Package: eudev
> Version: 3.2.9-4
> Severity: important
> 
> Hi,
> 
> the /etc/init.d/eudev initscript has this bit:
> 
> if ! ps -p1|grep -q "init\|systemd"; then
>   log_warning_msg "udevd does not support containers, not started"
>   exit 0
> fi

Thank you for your report.

So the name of pid 1 for runit-init is runit?
Then the test could be
-q "init\|runit\|systemd"

What about other init systems, like openrc-init? Perhaps the test should be
reversed if ps -p1 | -q "container tests here" instead.

The Debian package has a worse bug, the test is
if [ ! -w /sys ]; then which is always true, making it impossible to start udev
manually.

> If running with runit as the init system (which is obviously neither
> sysvinit nor systemd), the script exits without starting eudev, which
> results in no keyboard and mouse under X and no local way of switching to a
> text console.
> 
> Perhaps use virt-what to detect containers instead?

I've been looking for methods to detect containers, but have not found virt-
what. Do you have a link or a description?

Acknowledgement sent to [email protected]:
Extra info received and forwarded to list. Copy sent to Devuan Dev Team <[email protected]>. Full text available.

Information forwarded to [email protected], Devuan Dev Team <[email protected]>:
bug#392; Package eudev. Full text available.

Message received at [email protected]:

Received: (at submit) by bugs.devuan.org; 9 Feb 2020 10:36:10 +0000
Return-Path: <[email protected]>
Delivered-To: [email protected]
Received: from tupac3.dyne.org [195.169.149.119]
	by doc.devuan.org with IMAP (fetchmail-6.4.0.beta4)
	for <debbugs@localhost> (single-drop); Sun, 09 Feb 2020 10:36:10 +0000 (UTC)
Received: from flamant.cae-engineering.hu (flamant.cae-engineering.hu [62.210.203.57])
	by vm6.ganeti.dyne.org (Postfix) with ESMTP id 2C2DEF608BE
	for <[email protected]>; Sun,  9 Feb 2020 11:34:54 +0100 (CET)
Received: (qmail 54715 invoked from network); 9 Feb 2020 11:34:54 +0100
Received: from flamant.amavis.cae-engineering.hu (HELO localhost) (172.18.30.131)
  by flamant.qmail.cae-engineering.hu with ESMTP; 9 Feb 2020 11:34:54 +0100
X-Virus-Scanned: by amavisd-new-2.7.1 (20120429) at cae-engineering.hu
Received: from unknown ([172.18.30.1])
	by localhost (flamant.amavis.cae-engineering.hu [172.18.30.131]) (amavisd-new, port 1628)
	id DA246nol7m4l for <[email protected]>;
	Sun,  9 Feb 2020 11:34:48 +0100 (CET)
Received: from akorn-home.user.vpn.cae-engineering.hu (HELO hellgate.av.hu) (172.18.28.253)
  by flamant.cae-engineering.hu with ESMTP; 9 Feb 2020 11:34:48 +0100
Received: (qmail 24661 invoked by uid 1000); 9 Feb 2020 11:34:48 +0100
Date: Sun, 9 Feb 2020 11:34:48 +0100
From: KORN Andras <[email protected]>
To: Devuan Bug Tracking System <[email protected]>
Subject: When pid1==runit, mis-detects container and doesn't start
Message-ID: <20200209103448.lancgj764wum4y4x@hellgate>
X-Reportbug-Version: 7.5.1+devuan1
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
X-Spam-Status: No, score=0.0 required=5.0 tests=none autolearn=disabled
	version=3.4.2
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on tupac3.dyne.org

Package: eudev
Version: 3.2.9-4
Severity: important

Hi,

the /etc/init.d/eudev initscript has this bit:

if ! ps -p1|grep -q "init\|systemd"; then
  log_warning_msg "udevd does not support containers, not started"
  exit 0
fi

If running with runit as the init system (which is obviously neither
sysvinit nor systemd), the script exits without starting eudev, which
results in no keyboard and mouse under X and no local way of switching to a
text console.

Perhaps use virt-what to detect containers instead?

András

-- 
                   Can February March? No, but April May...

Acknowledgement sent to KORN Andras <[email protected]>:
New bug report received and forwarded. Copy sent to Devuan Dev Team <[email protected]>.

Your message specified a Severity: in the pseudo-header, but the severity value important was not recognised. The default severity normal is being used instead. The recognised values are: critical, grave, normal, minor, wishlist.

Full text available.

Report forwarded to [email protected], Devuan Dev Team <[email protected]>:
bug#392; Package eudev. Full text available.

Devuan bug report logs - #392 When pid1==runit, mis-detects container and doesn't start

Message received at [email protected]:

Message received at [email protected]:

Message received at [email protected]:

Message received at [email protected]:

Devuan bug report logs - #392
When pid1==runit, mis-detects container and doesn't start