Devuan bug report logs - #625
amprolla generates InRelease without arch:all

Package: amprolla; Reported by: Boian Bonev <[email protected]>; Done: Mark Hindley <[email protected]>; Maintainer for amprolla is (unknown).

Message received at [email protected]:

Date: Tue, 26 Oct 2021 17:07:18 +0100
From: Mark Hindley <[email protected]>
To: [email protected]
Subject: Re: bug#625: amprolla generates InRelease without arch:all
Message-ID: <[email protected]>
References: <[email protected]>
 <[email protected]>
 <[email protected]>
 <[email protected]>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <[email protected]>

Deployed and appears to be working as expected.

Closing.

Mark

Notification sent to Boian Bonev <[email protected]>:
bug acknowledged by developer. Full text available.

Reply sent to Mark Hindley <[email protected]>:
You have taken responsibility. Full text available.

Message received at [email protected]:

Date: Mon, 25 Oct 2021 17:52:30 +0100
From: Mark Hindley <[email protected]>
To: [email protected]
Subject: Re: bug#625: amprolla generates InRelease without arch:all
Message-ID: <[email protected]>
References: <[email protected]>
 <[email protected]>
 <[email protected]>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="V9HfQo3fysRZ318d"
Content-Disposition: inline
In-Reply-To: <[email protected]>

--V9HfQo3fysRZ318d
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

Boian and Ralph,

Thanks. I think I understand this now. Documenting it here, so we have it as a
reference.

Previously arch:all packages were included in arch specific index files (both
Packages and Contents). Obviously that is a duplication and from the Bullseye
cycle Debian has moved to reduce that duplication.  This requires clients to use
arch:all indicies directly, for which 'all' has to be included in the Release
Architectures (as Boian pointed out).

However, so this can be done in stages, the 'No-Support-for-Architecture-all:
Packages'[1] header was introduced which temporarily excludes Packages indicies
from the migration.

The inclusion of 'all' in Architectures is controlled in DAK by the per-suite
separate_{package,contents}_architecture_all options.

If we set

 separate_package_architecture_all=no
 separate_contents_architecture_all=yes

in DAK, we get 'all' added to Release Architectures and also
'No-Support-for-Architecture-all: Packages'. WHen merging, amprolla can then
test for 'all' in Devuan's DAK Release file and propagate that and the
No-Support-for-Architecture-all header to the merged Release file.

I prefer this approach as it keeps the configuration of this in a single place
(DAK) and doesn't change the behaviour for older releases (beowulf and earlier)
that still have dupicated arch:all.

Patch to be tested attached. I will change the config of ceres so it can
be tested.

Any comments/problems anybody can see?

Thanks

Mark

[1]  https://wiki.debian.org/DebianRepository/Format#No-Support-for-Architecture-all

--V9HfQo3fysRZ318d
Content-Type: text/x-diff; charset=us-ascii
Content-Disposition: attachment;
	filename="0001-Include-all-in-Release-architectures-if-it-is-config.patch"

From fb4e747cae4679ab0e5a41b1eb98f5e8ea521721 Mon Sep 17 00:00:00 2001
From: Mark Hindley <[email protected]>
Date: Sun, 24 Oct 2021 18:21:50 +0100
Subject: [PATCH] Include 'all' in Release architectures if it is configured in
 DAK.

Set separate_{contents,packages}_architecture_all=False|True for the suite.
---
 lib/config.def.py | 1 +
 lib/release.py    | 3 ++-
 2 files changed, 3 insertions(+), 1 deletion(-)

diff --git a/lib/config.def.py b/lib/config.def.py
index 59b5be8..b83ef44 100644
--- a/lib/config.def.py
+++ b/lib/config.def.py
@@ -312,6 +312,7 @@ release_keys = [
     'Components',
     'Description',
     'NotAutomatic',
+    'No-Support-for-Architecture-all',
     'ButAutomaticUpgrades',
     'Acquire-By-Hash',
 ]
diff --git a/lib/release.py b/lib/release.py
index 3099568..a264874 100644
--- a/lib/release.py
+++ b/lib/release.py
@@ -121,7 +121,8 @@ def write_release(oldrel, newrel, filelist, rmstr, rewrite=True):
     for i in arches(rel_cont['Codename']):
         if i == 'source':
             continue
-        if i == 'binary-all':
+        if i == 'binary-all' and not 'all' in rel_cont['Architectures'].split():
+            # DAK configuration separate_{contents,packages}_architecture_all=False
             continue
         i = i.replace('binary-', ' ')
         _archlist += i
-- 
2.20.1

--V9HfQo3fysRZ318d--

Acknowledgement sent to Mark Hindley <[email protected]>:
Extra info received and forwarded to list. Copy sent to Evilham <[email protected]>. Full text available.

Information forwarded to [email protected], Evilham <[email protected]>:
bug#625; Package amprolla. Full text available.

Message received at [email protected]:

Received: (at 625) by bugs.devuan.org; 24 Oct 2021 07:10:02 +0000
Return-Path: <[email protected]>
Delivered-To: [email protected]
Received: from tupac3.dyne.org [195.169.149.119]
	by doc.devuan.org with IMAP (fetchmail-6.4.0.beta4)
	for <debbugs@localhost> (single-drop); Sun, 24 Oct 2021 07:10:02 +0000 (UTC)
Received: from mx.hindley.org.uk (193-36-131-86.cfwn.uk [193.36.131.86])
	(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
	(No client certificate requested)
	by vm6.ganeti.dyne.org (Postfix) with ESMTPS id E3340F609FA
	for <[email protected]>; Sun, 24 Oct 2021 09:04:24 +0200 (CEST)
Received: from apollo.hindleynet ([192.168.1.3] helo=hindley.org.uk)
	by mx.hindley.org.uk with smtp (Exim 4.84_2)
	(envelope-from <[email protected]>)
	id 1meXYN-0004Er-CP; Sun, 24 Oct 2021 08:04:23 +0100
Received: (nullmailer pid 28413 invoked by uid 1000);
	Sun, 24 Oct 2021 07:04:22 -0000
Date: Sun, 24 Oct 2021 08:04:22 +0100
From: Mark Hindley <[email protected]>
To: [email protected]
Cc: [email protected]
Subject: Re: bug#625: amprolla generates InRelease without arch:all
Message-ID: <[email protected]>
References: <[email protected]>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <[email protected]>
X-Spam-Status: No, score=0.4 required=5.0 tests=RDNS_DYNAMIC,SPF_PASS
	autolearn=disabled version=3.4.2
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on tupac3.dyne.org

Boian,

Thanks for this.

On Sun, Oct 24, 2021 at 03:49:49AM +0300, Where all about bugs in Devuan packages is reported wrote:
> Package: amprolla
> Version: chimaera
> Severity: normal
> X-Debbugs-Cc: [email protected]
> 
> It was reported on #devuan that "apt-file search" does not find some files
> while it finds others. The files in question were in arch:all packages.
> apt-file makes apt-get also fetch Contents-* and apt-get skips Contents-all
> on chimaera.
> 
> It was also reported that the same works fine in beowulf and bullseye.
> 
> After further checking, beowulf's and chimaera's InRelease does not have all
> in the arch list while bullseye has it.

I think there is something else going on here. If it works in beowulf but
beowulf's InRelease doesn't have arch:all in the list, that can't be the cause.

Arch all packages are (now) supposed to be duplicated in all the
binary-*/Packages files.

Can you give me an example package which is missing? The significant thing is
whether it is a forked or unforked package. That may point to a DAK
configuration error.

Thanks

Mark

Acknowledgement sent to Mark Hindley <[email protected]>:
Extra info received and forwarded to list. Copy sent to Evilham <[email protected]>. Full text available.

Information forwarded to [email protected], Evilham <[email protected]>:
bug#625; Package amprolla. Full text available.

Message received at [email protected]:

Received: (at submit) by bugs.devuan.org; 24 Oct 2021 00:50:04 +0000
Return-Path: <[email protected]>
Delivered-To: [email protected]
Received: from tupac3.dyne.org [195.169.149.119]
	by doc.devuan.org with IMAP (fetchmail-6.4.0.beta4)
	for <debbugs@localhost> (single-drop); Sun, 24 Oct 2021 00:50:04 +0000 (UTC)
Received: from [10.10.10.6] (office.ipacct.com [195.85.215.8])
	by vm6.ganeti.dyne.org (Postfix) with ESMTP id 7D99DF608DC
	for <[email protected]>; Sun, 24 Oct 2021 02:49:51 +0200 (CEST)
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
From: Boian Bonev <[email protected]>
To: Devuan Bug Tracking System <[email protected]>
Subject: amprolla generates InRelease without arch:all
Message-ID: <163503658951.2389.1470505296025495898.reportbug@ipacct2>
Date: Sun, 24 Oct 2021 03:49:49 +0300
X-Spam-Status: No, score=0.2 required=5.0 tests=HELO_MISC_IP,SPF_PASS
	autolearn=disabled version=3.4.2
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on tupac3.dyne.org

Package: amprolla
Version: chimaera
Severity: normal
X-Debbugs-Cc: [email protected]

It was reported on #devuan that "apt-file search" does not find some files
while it finds others. The files in question were in arch:all packages.
apt-file makes apt-get also fetch Contents-* and apt-get skips Contents-all
on chimaera.

It was also reported that the same works fine in beowulf and bullseye.

After further checking, beowulf's and chimaera's InRelease does not have all
in the arch list while bullseye has it.

It looks like all is skipped in lib/release.py lines 69 and 70, but it is not
clear what will be the consequences if this gets changed.


-- System Information:
Distributor ID:	Devuan
Description:	Devuan GNU/Linux 4 (chimaera)
Release:	4
Codename:	chimaera
Architecture: x86_64

Kernel: Linux 5.10.0-8-amd64 (SMP w/32 CPU threads)
Kernel taint flags: TAINT_PROPRIETARY_MODULE, TAINT_CPU_OUT_OF_SPEC, TAINT_OOT_MODULE, TAINT_UNSIGNED_MODULE
Locale: LANG=C.UTF-8, LC_CTYPE=C.UTF-8 (charmap=UTF-8), LANGUAGE not set
Shell: /bin/sh linked to /bin/dash
Init: sysvinit (via /sbin/init)
LSM: AppArmor: enabled

Acknowledgement sent to Boian Bonev <[email protected]>:
New bug report received and forwarded. Copy sent to [email protected], Evilham <[email protected]>. Full text available.

Report forwarded to [email protected], [email protected], Evilham <[email protected]>:
bug#625; Package amprolla. Full text available.

Devuan bug report logs - #625 amprolla generates InRelease without arch:all

Message received at [email protected]:

Message received at [email protected]:

Message received at [email protected]:

Message received at [email protected]:

Devuan bug report logs - #625
amprolla generates InRelease without arch:all