Home | Devuan | Git | Forum | Packages | Popcon
Donate now!
Download

Devuan bug report logs - #697
/etc/default/grub.d/xen.cfg: Extraneous output line causes error message at boot

Package: xen-hypervisor-common; Severity: minor; Reported by: "John E. Krokes" <[email protected]>; Keywords: debian; Done: Mark Hindley <[email protected]>; Maintainer for xen-hypervisor-common is (unknown).

Message received at [email protected]:


Received: (at 697-done) by bugs.devuan.org; 11 Jan 2023 10:09:02 +0000
Return-Path: <[email protected]>
Delivered-To: [email protected]
Received: from email.devuan.org [2001:41d0:2:d06e::5c4:2612]
	by doc.devuan.org with IMAP (fetchmail-6.4.16)
	for <debbugs@localhost> (single-drop); Wed, 11 Jan 2023 10:09:02 +0000 (UTC)
Received: from email.devuan.org
	by email.devuan.org with LMTP
	id U/eTOZyKvmOFbAAAmSBk0A
	(envelope-from <[email protected]>)
	for <[email protected]>; Wed, 11 Jan 2023 10:08:28 +0000
Received: by email.devuan.org (Postfix, from userid 109)
	id E4509B85; Wed, 11 Jan 2023 10:08:28 +0000 (UTC)
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on email.devuan.org
X-Spam-Level: 
X-Spam-Status: No, score=0.4 required=5.0 tests=RDNS_DYNAMIC,SPF_PASS
	autolearn=no autolearn_force=no version=3.4.6
Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=193.36.131.86; helo=mx.hindley.org.uk; [email protected]; receiver=<UNKNOWN> 
Received: from mx.hindley.org.uk (193-36-131-86.cfwn.uk [193.36.131.86])
	by email.devuan.org (Postfix) with ESMTPS id 88233226
	for <[email protected]>; Wed, 11 Jan 2023 10:08:28 +0000 (UTC)
Received: from apollo.hindleynet ([192.168.1.3] helo=hindley.org.uk)
	by mx.hindley.org.uk with smtp (Exim 4.84_2)
	(envelope-from <[email protected]>)
	id 1pFY1z-0000oP-Hx
	for [email protected]; Wed, 11 Jan 2023 10:08:27 +0000
Received: (nullmailer pid 11287 invoked by uid 1000);
	Wed, 11 Jan 2023 10:08:27 -0000
Date: Wed, 11 Jan 2023 10:08:27 +0000
From: Mark Hindley <[email protected]>
To: [email protected]
Subject: Fixed in Debian #1016547
Message-ID: <Y76Km/[email protected]>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
X-Debbugs-No-Ack: No Thanks

Version: 4.16.2-1
Notification sent to "John E. Krokes" <[email protected]>:
bug acknowledged by developer. Full text available.
Reply sent to Mark Hindley <[email protected]>:
You have taken responsibility. Full text available.
Set bug forwarded-to-address to 'https://bugs.debian.org/1016547'. Request was from Mark Hindley <[email protected]> to [email protected]. Full text available.
Added tag(s) debian. Request was from Mark Hindley <[email protected]> to [email protected]. Full text available.

Message received at [email protected]:


Received: (at 697) by bugs.devuan.org; 2 Aug 2022 15:51:11 +0000
Return-Path: <[email protected]>
Delivered-To: [email protected]
Received: from mail.dyne.org [141.95.83.167]
	by doc.devuan.org with IMAP (fetchmail-6.4.16)
	for <debbugs@localhost> (single-drop); Tue, 02 Aug 2022 15:51:11 +0000 (UTC)
Received: from mx.hindley.org.uk (193-36-131-86.cfwn.uk [193.36.131.86])
	(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
	(No client certificate requested)
	by mail.dyne.org (Postfix) with ESMTPS id 95FC366187C
	for <[email protected]>; Tue,  2 Aug 2022 17:50:32 +0200 (CEST)
Received: from apollo.hindleynet ([192.168.1.3] helo=hindley.org.uk)
	by mx.hindley.org.uk with smtp (Exim 4.84_2)
	(envelope-from <[email protected]>)
	id 1oIuAA-0004A9-ON; Tue, 02 Aug 2022 16:50:30 +0100
Received: (nullmailer pid 17052 invoked by uid 1000);
	Tue, 02 Aug 2022 15:50:29 -0000
Date: Tue, 2 Aug 2022 16:50:29 +0100
From: Mark Hindley <[email protected]>
To: "John E. Krokes" <[email protected]>, [email protected]
Subject: Re: bug#697: /etc/default/grub.d/xen.cfg: Extraneous output line
 causes error message at boot
Message-ID: <[email protected]>
References: <165938651342.16705.8672993380929509725.reportbug@decay.netherworld.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <165938651342.16705.8672993380929509725.reportbug@decay.netherworld.org>
X-Debbugs-No-Ack: No Thanks
X-Spam-Status: No, score=0.4 required=5.0 tests=RCVD_IN_DNSWL_BLOCKED,
	RDNS_DYNAMIC,SPF_PASS autolearn=disabled version=3.4.2
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on mail.dyne.org

Control: tags -1 debian

John,

Thanks.

On Mon, Aug 01, 2022 at 04:41:53PM -0400, John E. Krokes wrote:
> Package: xen-hypervisor-common
> Version: 4.14.5+24-g87d90d511c-1
> Severity: minor
> File: /etc/default/grub.d/xen.cfg

Neither grrub nor xen are forked in Devuan and we use Debian's packages directly
without recompilation. Please report this issue to Debian's BTS to be addressed.

Thanks

Mark
Information forwarded to [email protected], [email protected]:
bug#697; Package xen-hypervisor-common. Full text available.

Message received at [email protected]:


Received: (at submit) by bugs.devuan.org; 2 Aug 2022 09:04:39 +0000
Return-Path: <[email protected]>
Delivered-To: [email protected]
Received: from mail.dyne.org [141.95.83.167]
	by doc.devuan.org with IMAP (fetchmail-6.4.16)
	for <debbugs@localhost> (single-drop); Tue, 02 Aug 2022 09:04:39 +0000 (UTC)
Received: from decay.netherworld.org (decay.netherworld.org [38.100.53.5])
	by mail.dyne.org (Postfix) with ESMTP id D32366618E7
	for <[email protected]>; Tue,  2 Aug 2022 11:04:03 +0200 (CEST)
Received: from decay.netherworld.org (localhost [127.0.0.1])
	by decay.netherworld.org (8.17.1/8.17.1) with ESMTP id 271Kfrqc016737;
	Mon, 1 Aug 2022 16:41:54 -0400
Received: (from mag@localhost)
	by decay.netherworld.org (8.17.1/8.17.1/Submit) id 271KfraA016736;
	Mon, 1 Aug 2022 16:41:53 -0400
X-Authentication-Warning: decay.netherworld.org: mag set sender to [email protected] using -f
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
From: "John E. Krokes" <[email protected]>
To: Devuan Bug Tracking System <[email protected]>
Subject: /etc/default/grub.d/xen.cfg: Extraneous output line causes error message at boot
Message-ID: <165938651342.16705.8672993380929509725.reportbug@decay.netherworld.org>
Date: Mon, 01 Aug 2022 16:41:53 -0400
X-Spam-Status: No, score=0.0 required=5.0 tests=none autolearn=disabled
	version=3.4.2
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on mail.dyne.org

Package: xen-hypervisor-common
Version: 4.14.5+24-g87d90d511c-1
Severity: minor
File: /etc/default/grub.d/xen.cfg

Dear Maintainer,

When invoked via grub-mkconfig, xen.cfg outputs this as its first line:
        Including Xen overrides from /etc/default/grub.d/xen.cfg

The output of grub-mkconfig is expected to be redirected into a grub.cfg file.
Grub will read the grub.cfg at boot. Unfortunately, "Including" is not a
valid grub command. So when booting, grub emits this error message before
displaying its menu:
	error: can't find command `Including'.


The error message is obscured very quickly. It does not affect functionality
in any way. It requires booting on a VERY slow machine in order to read
the error message at all.


If I add a '#' to the start of the "Including", the resulting grub config file
boots with no error.
	echo "#Including Xen overrides from /etc/default/grub.d/xen.cfg"


I'm not sure if this line was intended to go into the generated config
file as a comment, or if it was intended to be shown to the user while
grub-mkconfig is running.


I have observed this and tested my fix against version
4.14.5+24-g87d90d511c-1 of xen-hypervisor-common. I have also checked
with the debian git at https://salsa.debian.org/xen-team/debian-xen/-/blob/master/debian/tree/xen-hypervisor-common/etc/default/grub.d/xen.cfg. This line
has not changed in a very long time.


I can also duplicate the behavior using grub-emu, with the output redirected
to a file.



Thanks for your time.

-Mag


-- System Information:
Distributor ID:	Devuan
Description:	Devuan GNU/Linux 4 (chimaera)
Release:	4
Codename:	chimaera
Architecture: x86_64

Kernel: Linux 5.10.0-16-amd64 (SMP w/2 CPU threads)
Locale: LANG=C, LC_CTYPE=C.UTF-8 (charmap=UTF-8), LANGUAGE not set
Shell: /bin/sh linked to /bin/dash
Init: sysvinit (via /sbin/init)
LSM: AppArmor: enabled

-- Configuration Files:
/etc/default/grub.d/xen.cfg changed:
echo "Including Xen overrides from /etc/default/grub.d/xen.cfg"
XEN_OVERRIDE_GRUB_DEFAULT=0
if [ "$XEN_OVERRIDE_GRUB_DEFAULT" = "" ]; then
	echo "WARNING: GRUB_DEFAULT changed to boot into Xen by default!"
	echo "         Edit /etc/default/grub.d/xen.cfg to avoid this warning."
	XEN_OVERRIDE_GRUB_DEFAULT=1
fi
if [ "$XEN_OVERRIDE_GRUB_DEFAULT" = "1" ]; then
	GRUB_DEFAULT=$( \
		printf "$(gettext "%s, with Xen hypervisor")" \
		"$GRUB_DISTRIBUTOR GNU/Linux")
fi


-- no debconf information
Acknowledgement sent to "John E. Krokes" <[email protected]>:
New bug report received and forwarded. Copy sent to [email protected]. Full text available.
Report forwarded to [email protected], [email protected]:
bug#697; Package xen-hypervisor-common. Full text available.

Devuan BTS -- Powered by Debian bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.

Devuan Bugs Owner <[email protected]>.
Last modified: Sat, 30 Nov 2024 22:39:01 UTC