Devuan logs - #731, boring messages


Message sent to [email protected], [email protected]:


X-Loop: [email protected]
Subject: bug#731: needrestart -b on AMD processors complains of perl uninitialized variable
Reply-To: George Robbert <[email protected]>, [email protected]
Resent-From: George Robbert <[email protected]>
Resent-To: [email protected]
Resent-CC: [email protected]
X-Loop: [email protected]
Resent-Date: Thu, 22 Dec 2022 21:28:01 +0000
Resent-Message-ID: <[email protected]>
Resent-Sender: [email protected]
X-Devuan-PR-Message: report 731
X-Devuan-PR-Package: needrestart
X-Devuan-PR-Keywords: 
Received: via spool by [email protected] id=B.167174442424378
          (code B); Thu, 22 Dec 2022 21:28:01 +0000
Received: (at submit) by bugs.devuan.org; 22 Dec 2022 21:27:04 +0000
Delivered-To: [email protected]
Received: from email.devuan.org [2001:41d0:2:d06e::5c4:2612]
	by doc.devuan.org with IMAP (fetchmail-6.4.16)
	for <debbugs@localhost> (single-drop); Thu, 22 Dec 2022 21:27:04 +0000 (UTC)
Received: from email.devuan.org
	by email.devuan.org with LMTP
	id 1qcCIZTLpGPAFwAAmSBk0A
	(envelope-from <[email protected]>)
	for <[email protected]>; Thu, 22 Dec 2022 21:26:44 +0000
Received: by email.devuan.org (Postfix, from userid 109)
	id 775C7121D; Thu, 22 Dec 2022 21:26:44 +0000 (UTC)
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on email.devuan.org
X-Spam-Level: 
X-Spam-Status: No, score=-0.1 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6
Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=104.200.24.137; helo=yuki.minazuki.org; [email protected]; receiver=<UNKNOWN> 
Received: from yuki.minazuki.org (minazuki.org [104.200.24.137])
	by email.devuan.org (Postfix) with ESMTPS id DE02A226
	for <[email protected]>; Thu, 22 Dec 2022 21:26:39 +0000 (UTC)
Received: from xecty.minazuki.org (localhost [IPv6:::1])
	by yuki.minazuki.org (Postfix) with ESMTP id 90CC4140D8
	for <[email protected]>; Thu, 22 Dec 2022 14:26:34 -0700 (MST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=minazuki.org;
	s=dkim2048; t=1671744394;
	bh=fpLLTs0xlElVR9MuH1MnK37oAIM8j5QTpSHNkln08us=;
	h=From:To:Subject:Date:From;
	b=zZTgGlt4OrhfP0o981wF7SV5kfq30sOhqfU+r9ohbvCAhE70xIpXKV4e4coe4nIXD
	 oZrk8gkXRM3RPWS97v5jozdhub020v34dOftOi9qc3OQL/196RPRIs+l1z3hyMD9+P
	 Vva6Eu8gBpdcWCJZdfSB0AL40Wj+Dan/S1F93nmQqCAHAyM314A1uyXGMD1lvUFmRZ
	 EKZNWzPr1eElklMI8XwxDwdvfJ7tnpzAFT5qM/VVA6YPJ2TFo2ic10n6BF2lh5VI68
	 rJQHNlB6DXmOh2qaSAx4xtlRl/0YKF56+lTY7xvjVyDmGbbHOjyqamPb5X6nx5ddcr
	 Q1NDa4V0/kMXg==
Received: by xecty.minazuki.org (Postfix, from userid 1000)
	id 72D5720195; Thu, 22 Dec 2022 14:26:34 -0700 (MST)
Content-Type: multipart/mixed; boundary="===============6328687844274786659=="
MIME-Version: 1.0
From: George Robbert <[email protected]>
To: Devuan Bug Tracking System <[email protected]>
Message-ID: <167174439441.9836.13629055203656959955.reportbug@xecty.minazuki.org>
X-Mailer: reportbug 7.10.3+devuan1
Date: Thu, 22 Dec 2022 14:26:34 -0700

This is a multi-part MIME message sent by reportbug.


--===============6328687844274786659==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

Package: needrestart
Version: 3.5-4+deb11u2
Severity: normal

Dear Maintainer,

When running 'needrestart -b' on an AMD system, I get the following
uninitialized variable warning.  It also does not report the expected
microcode version (NEEDRESTART-UCEXP).  See output: section below for
example output of needrestart -b.

Use of uninitialized value $ucode_vars{"AVAIL"} in concatenation (.) or string at /usr/sbin/needrestart line 904.

This perl warning disappears when adding the -v option (needrestart -b -v),
and the correct value is reported for NEEDRESTART-UCEXP.


It looks to me like the problem is that line 182 of
/usr/share/perl5/NeedRestart/uCode/AMD.pm ends in a comma (,) instead
of a semicolon (;).  This means that assignment is subsumed into the
next line which is under if ($debug).

See the attached patch.  The debsum error reported below is due to my
applying this patch.

Thanks,
George Robbert



-- Package-specific info:
needrestart -b output:

NEEDRESTART-VER: 3.5
NEEDRESTART-KCUR: 5.10.0-20-amd64
NEEDRESTART-KEXP: 5.10.0-20-amd64
NEEDRESTART-KSTA: 1
NEEDRESTART-UCSTA: 1
NEEDRESTART-UCCUR: 0x03000027
Use of uninitialized value $ucode_vars{"AVAIL"} in concatenation (.) or string at /usr/sbin/needrestart line 904.
NEEDRESTART-UCEXP: 



-- System Information:
Distributor ID:	Devuan
Description:	Devuan GNU/Linux 4 (chimaera)
Release:	4
Codename:	chimaera
Architecture: x86_64

Kernel: Linux 5.10.0-20-amd64 (SMP w/2 CPU threads)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=ANSI_X3.4-1968) (ignored: LC_ALL set to C), LANGUAGE not set
Shell: /bin/sh linked to /usr/bin/dash
Init: sysvinit (via /sbin/init)

Versions of packages needrestart depends on:
ii  binutils                   2.35.2-2
ii  dpkg                       1.20.12
ii  gettext-base               0.21-4
ii  libintl-perl               1.26-3+deb11u1
ii  libmodule-find-perl        0.15-1
ii  libmodule-scandeps-perl    1.30-1
ii  libproc-processtable-perl  0.59-2+b1
ii  libsort-naturally-perl     1.03-2
ii  libterm-readkey-perl       2.38-1+b2
ii  perl                       5.32.1-4+deb11u2
ii  xz-utils                   5.2.5-2.1~deb11u1

Versions of packages needrestart recommends:
ii  libpam-elogind [libpam-systemd]  246.10-2
ii  sysvinit-core                    2.96-7+devuan2

Versions of packages needrestart suggests:
pn  iucode-tool                          <none>
pn  needrestart-session | libnotify-bin  <none>

-- Configuration Files:
/etc/apt/apt.conf.d/99needrestart changed:
DPkg::Post-Invoke {"test -x /usr/lib/needrestart/apt-pinvoke && /usr/lib/needrestart/apt-pinvoke -b || true"; };

/etc/needrestart/hook.d/20-rpm [Errno 2] No such file or directory: '/etc/needrestart/hook.d/20-rpm'

-- no debconf information

-- debsums errors found:
debsums: changed file /usr/share/perl5/NeedRestart/uCode/AMD.pm (from needrestart package)

--===============6328687844274786659==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment; filename="needrestart.patch"

--- /tmp/AMD.pm	2022-12-22 11:00:14.589106185 -0700
+++ /usr/share/perl5/NeedRestart/uCode/AMD.pm	2022-12-22 11:00:24.329046436 -0700
@@ -179,7 +179,7 @@
     if ( exists( $_ucodes->{cpuid}->{$cpuid} ) ) {
         my $prid = $_ucodes->{cpuid}->{$cpuid};
         if ( exists( $_ucodes->{prid}->{$prid} ) ) {
-            $vars{AVAIL} = sprintf( "0x%08x", $_ucodes->{prid}->{$prid} ),
+            $vars{AVAIL} = sprintf( "0x%08x", $_ucodes->{prid}->{$prid} );
 
               print STDERR "$LOGPREF #$info->{processor} found ucode $vars{AVAIL}\n" if ($debug);
             if ( $_ucodes->{prid}->{$prid} > $ucode ) {

--===============6328687844274786659==--

Message sent:


Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-Mailer: MIME-tools 5.509 (Entity 5.509)
Content-Type: text/plain; charset=utf-8
X-Loop: [email protected]
From: "Devuan bug Tracking System" <[email protected]>
To: George Robbert <[email protected]>
Subject: bug#731: Acknowledgement (needrestart -b on AMD processors
 complains of perl uninitialized variable)
Message-ID: <[email protected]>
References: <167174439441.9836.13629055203656959955.reportbug@xecty.minazuki.org>
X-Devuan-PR-Message: ack 731
X-Devuan-PR-Package: needrestart
Reply-To: [email protected]
Date: Thu, 22 Dec 2022 21:28:09 +0000

Thank you for filing a new bug report with Devuan.

You can follow progress on this bug here: 731: https://bugs.devuan.org/cgi/=
bugreport.cgi?bug=3D731.

This is an automatically generated reply to let you know your message
has been received.

Your message is being forwarded to the package maintainers and other
interested parties for their attention; they will reply in due course.

Your message has been sent to the package maintainer(s):
 [email protected]

If you wish to submit further information on this problem, please
send it to [email protected].

Please do not send mail to [email protected] unless you wish
to report a problem with the Bug-tracking system.

--=20
731: https://bugs.devuan.org/cgi/bugreport.cgi?bug=3D731
Devuan Bug Tracking System
Contact [email protected] with problems

Message sent to [email protected], [email protected]:


X-Loop: [email protected]
Subject: bug#731: needrestart -b on AMD processors complains of perl uninitialized variable
Reply-To: Mark Hindley <[email protected]>, [email protected]
Resent-From: Mark Hindley <[email protected]>
Resent-To: [email protected]
Resent-CC: [email protected]
X-Loop: [email protected]
Resent-Date: Fri, 23 Dec 2022 09:42:02 +0000
Resent-Message-ID: <[email protected]>
Resent-Sender: [email protected]
X-Devuan-PR-Message: followup 731
X-Devuan-PR-Package: needrestart
X-Devuan-PR-Keywords: 
References: <167174439441.9836.13629055203656959955.reportbug@xecty.minazuki.org> <167174439441.9836.13629055203656959955.reportbug@xecty.minazuki.org>
Received: via spool by [email protected] id=B731.167178843527123
          (code B ref 731); Fri, 23 Dec 2022 09:42:02 +0000
Received: (at 731) by bugs.devuan.org; 23 Dec 2022 09:40:35 +0000
Delivered-To: [email protected]
Received: from email.devuan.org [2001:41d0:2:d06e::5c4:2612]
	by doc.devuan.org with IMAP (fetchmail-6.4.16)
	for <debbugs@localhost> (single-drop); Fri, 23 Dec 2022 09:40:35 +0000 (UTC)
Received: from email.devuan.org
	by email.devuan.org with LMTP
	id ksEQC493pWOEOQAAmSBk0A
	(envelope-from <[email protected]>)
	for <[email protected]>; Fri, 23 Dec 2022 09:40:31 +0000
Received: by email.devuan.org (Postfix, from userid 109)
	id 23F781222; Fri, 23 Dec 2022 09:40:31 +0000 (UTC)
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on email.devuan.org
X-Spam-Level: 
X-Spam-Status: No, score=0.4 required=5.0 tests=RDNS_DYNAMIC,SPF_PASS
	autolearn=no autolearn_force=no version=3.4.6
Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=193.36.131.86; helo=mx.hindley.org.uk; [email protected]; receiver=<UNKNOWN> 
Received: from mx.hindley.org.uk (193-36-131-86.cfwn.uk [193.36.131.86])
	by email.devuan.org (Postfix) with ESMTPS id 0EBFB2A8
	for <[email protected]>; Fri, 23 Dec 2022 09:40:25 +0000 (UTC)
Received: from apollo.hindleynet ([192.168.1.3] helo=hindley.org.uk)
	by mx.hindley.org.uk with smtp (Exim 4.84_2)
	(envelope-from <[email protected]>)
	id 1p8eXJ-00027m-B3; Fri, 23 Dec 2022 09:40:17 +0000
Received: (nullmailer pid 16469 invoked by uid 1000);
	Fri, 23 Dec 2022 09:40:16 -0000
Date: Fri, 23 Dec 2022 09:40:16 +0000
From: Mark Hindley <[email protected]>
To: George Robbert <[email protected]>, [email protected]
Message-ID: <[email protected]>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <167174439441.9836.13629055203656959955.reportbug@xecty.minazuki.org>

Control: tags -1 debian
Control: forwarded -1  https://bugs.debian.org/973050

George,

On Thu, Dec 22, 2022 at 02:26:34PM -0700, George Robbert wrote:
> Package: needrestart
> Version: 3.5-4+deb11u2
> Severity: normal

Many thanks for this.

However, needrestart is not a forked package and Devuan uses Debian's packages
directly without recompilation. Indeed this issue seems to have been reported
already to Debian's BTS[1]. Perhaps you could add your voice and patch to that
report?

Thanks

Mark

[1]  https://bugs.debian.org/973050

Message received at [email protected]:


Received: (at 731) by bugs.devuan.org; 23 Dec 2022 09:40:35 +0000
Return-Path: <[email protected]>
Delivered-To: [email protected]
Received: from email.devuan.org [2001:41d0:2:d06e::5c4:2612]
	by doc.devuan.org with IMAP (fetchmail-6.4.16)
	for <debbugs@localhost> (single-drop); Fri, 23 Dec 2022 09:40:35 +0000 (UTC)
Received: from email.devuan.org
	by email.devuan.org with LMTP
	id ksEQC493pWOEOQAAmSBk0A
	(envelope-from <[email protected]>)
	for <[email protected]>; Fri, 23 Dec 2022 09:40:31 +0000
Received: by email.devuan.org (Postfix, from userid 109)
	id 23F781222; Fri, 23 Dec 2022 09:40:31 +0000 (UTC)
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on email.devuan.org
X-Spam-Level: 
X-Spam-Status: No, score=0.4 required=5.0 tests=RDNS_DYNAMIC,SPF_PASS
	autolearn=no autolearn_force=no version=3.4.6
Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=193.36.131.86; helo=mx.hindley.org.uk; [email protected]; receiver=<UNKNOWN> 
Received: from mx.hindley.org.uk (193-36-131-86.cfwn.uk [193.36.131.86])
	by email.devuan.org (Postfix) with ESMTPS id 0EBFB2A8
	for <[email protected]>; Fri, 23 Dec 2022 09:40:25 +0000 (UTC)
Received: from apollo.hindleynet ([192.168.1.3] helo=hindley.org.uk)
	by mx.hindley.org.uk with smtp (Exim 4.84_2)
	(envelope-from <[email protected]>)
	id 1p8eXJ-00027m-B3; Fri, 23 Dec 2022 09:40:17 +0000
Received: (nullmailer pid 16469 invoked by uid 1000);
	Fri, 23 Dec 2022 09:40:16 -0000
Date: Fri, 23 Dec 2022 09:40:16 +0000
From: Mark Hindley <[email protected]>
To: George Robbert <[email protected]>, [email protected]
Subject: Re: bug#731: needrestart -b on AMD processors complains of perl
 uninitialized variable
Message-ID: <[email protected]>
References: <167174439441.9836.13629055203656959955.reportbug@xecty.minazuki.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <167174439441.9836.13629055203656959955.reportbug@xecty.minazuki.org>
X-Debbugs-No-Ack: No Thanks

Control: tags -1 debian
Control: forwarded -1  https://bugs.debian.org/973050

George,

On Thu, Dec 22, 2022 at 02:26:34PM -0700, George Robbert wrote:
> Package: needrestart
> Version: 3.5-4+deb11u2
> Severity: normal

Many thanks for this.

However, needrestart is not a forked package and Devuan uses Debian's packages
directly without recompilation. Indeed this issue seems to have been reported
already to Debian's BTS[1]. Perhaps you could add your voice and patch to that
report?

Thanks

Mark

[1]  https://bugs.debian.org/973050


Message received at [email protected]:


Received: (at 731) by bugs.devuan.org; 23 Dec 2022 09:40:35 +0000
Return-Path: <[email protected]>
Delivered-To: [email protected]
Received: from email.devuan.org [2001:41d0:2:d06e::5c4:2612]
	by doc.devuan.org with IMAP (fetchmail-6.4.16)
	for <debbugs@localhost> (single-drop); Fri, 23 Dec 2022 09:40:35 +0000 (UTC)
Received: from email.devuan.org
	by email.devuan.org with LMTP
	id ksEQC493pWOEOQAAmSBk0A
	(envelope-from <[email protected]>)
	for <[email protected]>; Fri, 23 Dec 2022 09:40:31 +0000
Received: by email.devuan.org (Postfix, from userid 109)
	id 23F781222; Fri, 23 Dec 2022 09:40:31 +0000 (UTC)
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on email.devuan.org
X-Spam-Level: 
X-Spam-Status: No, score=0.4 required=5.0 tests=RDNS_DYNAMIC,SPF_PASS
	autolearn=no autolearn_force=no version=3.4.6
Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=193.36.131.86; helo=mx.hindley.org.uk; [email protected]; receiver=<UNKNOWN> 
Received: from mx.hindley.org.uk (193-36-131-86.cfwn.uk [193.36.131.86])
	by email.devuan.org (Postfix) with ESMTPS id 0EBFB2A8
	for <[email protected]>; Fri, 23 Dec 2022 09:40:25 +0000 (UTC)
Received: from apollo.hindleynet ([192.168.1.3] helo=hindley.org.uk)
	by mx.hindley.org.uk with smtp (Exim 4.84_2)
	(envelope-from <[email protected]>)
	id 1p8eXJ-00027m-B3; Fri, 23 Dec 2022 09:40:17 +0000
Received: (nullmailer pid 16469 invoked by uid 1000);
	Fri, 23 Dec 2022 09:40:16 -0000
Date: Fri, 23 Dec 2022 09:40:16 +0000
From: Mark Hindley <[email protected]>
To: George Robbert <[email protected]>, [email protected]
Subject: Re: bug#731: needrestart -b on AMD processors complains of perl
 uninitialized variable
Message-ID: <[email protected]>
References: <167174439441.9836.13629055203656959955.reportbug@xecty.minazuki.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <167174439441.9836.13629055203656959955.reportbug@xecty.minazuki.org>
X-Debbugs-No-Ack: No Thanks

Control: tags -1 debian
Control: forwarded -1  https://bugs.debian.org/973050

George,

On Thu, Dec 22, 2022 at 02:26:34PM -0700, George Robbert wrote:
> Package: needrestart
> Version: 3.5-4+deb11u2
> Severity: normal

Many thanks for this.

However, needrestart is not a forked package and Devuan uses Debian's packages
directly without recompilation. Indeed this issue seems to have been reported
already to Debian's BTS[1]. Perhaps you could add your voice and patch to that
report?

Thanks

Mark

[1]  https://bugs.debian.org/973050


Message sent to [email protected], [email protected]:


X-Loop: [email protected]
Subject: bug#731: needrestart -b on AMD processors complains of perl uninitialized variable
Reply-To: George Robbert <[email protected]>, [email protected]
Resent-From: George Robbert <[email protected]>
Resent-To: [email protected]
Resent-CC: [email protected]
X-Loop: [email protected]
Resent-Date: Sat, 24 Dec 2022 01:46:01 +0000
Resent-Message-ID: <[email protected]>
Resent-Sender: [email protected]
X-Devuan-PR-Message: followup 731
X-Devuan-PR-Package: needrestart
X-Devuan-PR-Keywords: debian
References: <167174439441.9836.13629055203656959955.reportbug@xecty.minazuki.org>
Received: via spool by [email protected] id=B731.167184630524534
          (code B ref 731); Sat, 24 Dec 2022 01:46:01 +0000
Received: (at 731) by bugs.devuan.org; 24 Dec 2022 01:45:05 +0000
Delivered-To: [email protected]
Received: from email.devuan.org [2001:41d0:2:d06e::5c4:2612]
	by doc.devuan.org with IMAP (fetchmail-6.4.16)
	for <debbugs@localhost> (single-drop); Sat, 24 Dec 2022 01:45:05 +0000 (UTC)
Received: from email.devuan.org
	by email.devuan.org with LMTP
	id zMrjM2RZpmNobAAAmSBk0A
	(envelope-from <[email protected]>)
	for <[email protected]>; Sat, 24 Dec 2022 01:44:04 +0000
Received: by email.devuan.org (Postfix, from userid 109)
	id C3E1B1222; Sat, 24 Dec 2022 01:44:04 +0000 (UTC)
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on email.devuan.org
X-Spam-Level: 
X-Spam-Status: No, score=-0.1 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6
Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=104.200.24.137; helo=yuki.minazuki.org; [email protected]; receiver=<UNKNOWN> 
Received: from yuki.minazuki.org (minazuki.org [104.200.24.137])
	by email.devuan.org (Postfix) with ESMTPS id 5739DB0D
	for <[email protected]>; Sat, 24 Dec 2022 01:43:59 +0000 (UTC)
Received: from sachiko.minazuki.org (localhost [IPv6:::1])
	by yuki.minazuki.org (Postfix) with ESMTP id C766C14003
	for <[email protected]>; Fri, 23 Dec 2022 18:43:55 -0700 (MST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=minazuki.org;
	s=dkim2048; t=1671846235;
	bh=DHqB2P2/Uq5sqQR1HlEeTfoX6Zd1LBkGCWjBrj6QEVo=;
	h=To:From:Subject:Date:From;
	b=f89c9BKbg+nx17MVHsrF+wFmwohmM4O8DTjMQKpc/Fi7kECJhgVfD5DKz2PuuLlul
	 3Oe5LMdTPx2MlzWb8qj5vftcr1fjST9lLUIPE4ZsZ+/IYyejolGrfdEDTNjl3In6aB
	 fZN1l8WKBNWvJ0bfEMo740qjj14hFS9H0qT1f7/0HBnM8r3WY7eHloh5/KSpEr3kTJ
	 cbk/3BlzYUiSgM8pa/KBvJwG7o5p6kXWSB9Trn7/jaerEWF7GyLhq0qXy91hthz93o
	 eUl3izGEyg70KrSm/vcsn60PEfYfFLlGEUVw+w7B0Ljyk9VaUf5B2lsEqMiVuX7dar
	 Li6nOJ6WwwkyA==
Received: by sachiko.minazuki.org (Postfix, from userid 1000)
	id 9EDACC1741; Fri, 23 Dec 2022 18:43:55 -0700 (MST)
Received: from sachiko.minazuki.org (localhost [127.0.0.1])
	by sachiko.minazuki.org (Postfix) with ESMTP id 89D29C0A45
	for <[email protected]>; Fri, 23 Dec 2022 18:43:55 -0700 (MST)
To: [email protected]
From: George Robbert <[email protected]>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <[email protected]>
Date: Fri, 23 Dec 2022 18:43:55 -0700
Message-Id: <[email protected]>

Mark,

On Fri, 23 Dec 2022 09:40:16 +0000, Mark Hindley wrote:
> However, needrestart is not a forked package and Devuan uses Debian's packages
> directly without recompilation. Indeed this issue seems to have been reported
> already to Debian's BTS[1]. Perhaps you could add your voice and patch to that
> report?
> 
> Thanks
> 
> Mark
> 
> [1]  https://bugs.debian.org/973050

Thanks for pointing me in the right direction.

Looking at Debian bug #973050, I see that has similar symptoms, but a
different underlying cause to this bug.  So, I went ahead and
submitted a new bug to Debian[2].  If the maintainer decides that they
actually are the same underlying bug, he can merge this as a
duplicate.

Thanks,
George


[2] https://bugs.debian.org/1026927

Message sent:


Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-Mailer: MIME-tools 5.509 (Entity 5.509)
Content-Type: text/plain; charset=utf-8
X-Loop: [email protected]
From: "Devuan bug Tracking System" <[email protected]>
To: George Robbert <[email protected]>
Subject: bug#731: Info received (bug#731: needrestart -b on AMD processors
 complains of perl uninitialized variable)
Message-ID: <[email protected]>
References: <[email protected]>
X-Devuan-PR-Message: ack-info 731
X-Devuan-PR-Package: needrestart
X-Devuan-PR-Keywords: debian
Reply-To: [email protected]
Date: Sat, 24 Dec 2022 01:46:09 +0000

Thank you for the additional information you have supplied regarding
this bug report.

This is an automatically generated reply to let you know your message
has been received.

Your message is being forwarded to the package maintainers and other
interested parties for their attention; they will reply in due course.

Your message has been sent to the package maintainer(s):
 [email protected]

If you wish to submit further information on this problem, please
send it to [email protected].

Please do not send mail to [email protected] unless you wish
to report a problem with the Bug-tracking system.

--=20
731: https://bugs.devuan.org/cgi/bugreport.cgi?bug=3D731
Devuan Bug Tracking System
Contact [email protected] with problems

Message sent to [email protected], [email protected]:


X-Loop: [email protected]
Subject: bug#731: needrestart -b on AMD processors complains of perl uninitialized variable
Reply-To: Mark Hindley <[email protected]>, [email protected]
Resent-From: Mark Hindley <[email protected]>
Resent-To: [email protected]
Resent-CC: [email protected]
X-Loop: [email protected]
Resent-Date: Sat, 24 Dec 2022 08:58:01 +0000
Resent-Message-ID: <[email protected]>
Resent-Sender: [email protected]
X-Devuan-PR-Message: followup 731
X-Devuan-PR-Package: needrestart
X-Devuan-PR-Keywords: debian
References: <167174439441.9836.13629055203656959955.reportbug@xecty.minazuki.org> <[email protected]> <167174439441.9836.13629055203656959955.reportbug@xecty.minazuki.org>
Received: via spool by [email protected] id=B731.167187224519931
          (code B ref 731); Sat, 24 Dec 2022 08:58:01 +0000
Received: (at 731) by bugs.devuan.org; 24 Dec 2022 08:57:25 +0000
Delivered-To: [email protected]
Received: from email.devuan.org [2001:41d0:2:d06e::5c4:2612]
	by doc.devuan.org with IMAP (fetchmail-6.4.16)
	for <debbugs@localhost> (single-drop); Sat, 24 Dec 2022 08:57:25 +0000 (UTC)
Received: from email.devuan.org
	by email.devuan.org with LMTP
	id Uo1MDqS+pmOnfQAAmSBk0A
	(envelope-from <[email protected]>)
	for <[email protected]>; Sat, 24 Dec 2022 08:56:04 +0000
Received: by email.devuan.org (Postfix, from userid 109)
	id 256FE1222; Sat, 24 Dec 2022 08:56:04 +0000 (UTC)
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on email.devuan.org
X-Spam-Level: 
X-Spam-Status: No, score=0.4 required=5.0 tests=RDNS_DYNAMIC,SPF_PASS
	autolearn=no autolearn_force=no version=3.4.6
Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=193.36.131.86; helo=mx.hindley.org.uk; [email protected]; receiver=<UNKNOWN> 
Received: from mx.hindley.org.uk (193-36-131-86.cfwn.uk [193.36.131.86])
	by email.devuan.org (Postfix) with ESMTPS id 0F5F4B0D
	for <[email protected]>; Sat, 24 Dec 2022 08:55:58 +0000 (UTC)
Received: from apollo.hindleynet ([192.168.1.3] helo=hindley.org.uk)
	by mx.hindley.org.uk with smtp (Exim 4.84_2)
	(envelope-from <[email protected]>)
	id 1p90Jr-0001Yy-2S; Sat, 24 Dec 2022 08:55:51 +0000
Received: (nullmailer pid 20493 invoked by uid 1000);
	Sat, 24 Dec 2022 08:55:50 -0000
Date: Sat, 24 Dec 2022 08:55:50 +0000
From: Mark Hindley <[email protected]>
To: George Robbert <[email protected]>, [email protected]
Message-ID: <Y6a+lt/qN/[email protected]>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <[email protected]>

Control: forwarded -1 https://bugs.debian.org/1026927

George,

Thanks.

Sorry for not noticing the underlying cause was different.

Mark

Message received at [email protected]:


Received: (at 731) by bugs.devuan.org; 24 Dec 2022 08:57:25 +0000
Return-Path: <[email protected]>
Delivered-To: [email protected]
Received: from email.devuan.org [2001:41d0:2:d06e::5c4:2612]
	by doc.devuan.org with IMAP (fetchmail-6.4.16)
	for <debbugs@localhost> (single-drop); Sat, 24 Dec 2022 08:57:25 +0000 (UTC)
Received: from email.devuan.org
	by email.devuan.org with LMTP
	id Uo1MDqS+pmOnfQAAmSBk0A
	(envelope-from <[email protected]>)
	for <[email protected]>; Sat, 24 Dec 2022 08:56:04 +0000
Received: by email.devuan.org (Postfix, from userid 109)
	id 256FE1222; Sat, 24 Dec 2022 08:56:04 +0000 (UTC)
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on email.devuan.org
X-Spam-Level: 
X-Spam-Status: No, score=0.4 required=5.0 tests=RDNS_DYNAMIC,SPF_PASS
	autolearn=no autolearn_force=no version=3.4.6
Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=193.36.131.86; helo=mx.hindley.org.uk; [email protected]; receiver=<UNKNOWN> 
Received: from mx.hindley.org.uk (193-36-131-86.cfwn.uk [193.36.131.86])
	by email.devuan.org (Postfix) with ESMTPS id 0F5F4B0D
	for <[email protected]>; Sat, 24 Dec 2022 08:55:58 +0000 (UTC)
Received: from apollo.hindleynet ([192.168.1.3] helo=hindley.org.uk)
	by mx.hindley.org.uk with smtp (Exim 4.84_2)
	(envelope-from <[email protected]>)
	id 1p90Jr-0001Yy-2S; Sat, 24 Dec 2022 08:55:51 +0000
Received: (nullmailer pid 20493 invoked by uid 1000);
	Sat, 24 Dec 2022 08:55:50 -0000
Date: Sat, 24 Dec 2022 08:55:50 +0000
From: Mark Hindley <[email protected]>
To: George Robbert <[email protected]>, [email protected]
Subject: Re: bug#731: needrestart -b on AMD processors complains of perl
 uninitialized variable
Message-ID: <Y6a+lt/qN/[email protected]>
References: <167174439441.9836.13629055203656959955.reportbug@xecty.minazuki.org>
 <[email protected]>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <[email protected]>
X-Debbugs-No-Ack: No Thanks

Control: forwarded -1 https://bugs.debian.org/1026927

George,

Thanks.

Sorry for not noticing the underlying cause was different.

Mark

Message sent:


MIME-Version: 1.0
X-Mailer: MIME-tools 5.509 (Entity 5.509)
X-Loop: [email protected]
From: "Devuan bug Tracking System" <[email protected]>
To: Mark Hindley <[email protected]>
Subject: bug#731: marked as done (needrestart -b on AMD processors
 complains of perl uninitialized variable)
Message-ID: <[email protected]>
References: <[email protected]>
 <167174439441.9836.13629055203656959955.reportbug@xecty.minazuki.org>
X-Devuan-PR-Message: closed 731
X-Devuan-PR-Package: needrestart
X-Devuan-PR-Keywords: debian
Reply-To: [email protected]
Date: Wed, 18 Jan 2023 20:14:01 +0000
Content-Type: multipart/mixed; boundary="----------=_1674072841-13098-0"

This is a multi-part message in MIME format...

------------=_1674072841-13098-0
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="utf-8"

Your message dated Wed, 18 Jan 2023 20:11:38 +0000
with message-id <[email protected]>
and subject line Fixed in Debian #1026927
has caused the Devuan bug report #731,
regarding needrestart -b on AMD processors complains of perl uninitialized =
variable
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)


--=20
731: https://bugs.devuan.org/cgi/bugreport.cgi?bug=3D731
Devuan Bug Tracking System
Contact [email protected] with problems

------------=_1674072841-13098-0
Content-Type: message/rfc822
Content-Disposition: inline
Content-Transfer-Encoding: 7bit

Received: (at submit) by bugs.devuan.org; 22 Dec 2022 21:27:04 +0000
Return-Path: <[email protected]>
Delivered-To: [email protected]
Received: from email.devuan.org [2001:41d0:2:d06e::5c4:2612]
	by doc.devuan.org with IMAP (fetchmail-6.4.16)
	for <debbugs@localhost> (single-drop); Thu, 22 Dec 2022 21:27:04 +0000 (UTC)
Received: from email.devuan.org
	by email.devuan.org with LMTP
	id 1qcCIZTLpGPAFwAAmSBk0A
	(envelope-from <[email protected]>)
	for <[email protected]>; Thu, 22 Dec 2022 21:26:44 +0000
Received: by email.devuan.org (Postfix, from userid 109)
	id 775C7121D; Thu, 22 Dec 2022 21:26:44 +0000 (UTC)
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on email.devuan.org
X-Spam-Level: 
X-Spam-Status: No, score=-0.1 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6
Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=104.200.24.137; helo=yuki.minazuki.org; [email protected]; receiver=<UNKNOWN> 
Received: from yuki.minazuki.org (minazuki.org [104.200.24.137])
	by email.devuan.org (Postfix) with ESMTPS id DE02A226
	for <[email protected]>; Thu, 22 Dec 2022 21:26:39 +0000 (UTC)
Received: from xecty.minazuki.org (localhost [IPv6:::1])
	by yuki.minazuki.org (Postfix) with ESMTP id 90CC4140D8
	for <[email protected]>; Thu, 22 Dec 2022 14:26:34 -0700 (MST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=minazuki.org;
	s=dkim2048; t=1671744394;
	bh=fpLLTs0xlElVR9MuH1MnK37oAIM8j5QTpSHNkln08us=;
	h=From:To:Subject:Date:From;
	b=zZTgGlt4OrhfP0o981wF7SV5kfq30sOhqfU+r9ohbvCAhE70xIpXKV4e4coe4nIXD
	 oZrk8gkXRM3RPWS97v5jozdhub020v34dOftOi9qc3OQL/196RPRIs+l1z3hyMD9+P
	 Vva6Eu8gBpdcWCJZdfSB0AL40Wj+Dan/S1F93nmQqCAHAyM314A1uyXGMD1lvUFmRZ
	 EKZNWzPr1eElklMI8XwxDwdvfJ7tnpzAFT5qM/VVA6YPJ2TFo2ic10n6BF2lh5VI68
	 rJQHNlB6DXmOh2qaSAx4xtlRl/0YKF56+lTY7xvjVyDmGbbHOjyqamPb5X6nx5ddcr
	 Q1NDa4V0/kMXg==
Received: by xecty.minazuki.org (Postfix, from userid 1000)
	id 72D5720195; Thu, 22 Dec 2022 14:26:34 -0700 (MST)
Content-Type: multipart/mixed; boundary="===============6328687844274786659=="
MIME-Version: 1.0
From: George Robbert <[email protected]>
To: Devuan Bug Tracking System <[email protected]>
Subject: needrestart -b on AMD processors complains of perl uninitialized variable
Message-ID: <167174439441.9836.13629055203656959955.reportbug@xecty.minazuki.org>
X-Mailer: reportbug 7.10.3+devuan1
Date: Thu, 22 Dec 2022 14:26:34 -0700

This is a multi-part MIME message sent by reportbug.


--===============6328687844274786659==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

Package: needrestart
Version: 3.5-4+deb11u2
Severity: normal

Dear Maintainer,

When running 'needrestart -b' on an AMD system, I get the following
uninitialized variable warning.  It also does not report the expected
microcode version (NEEDRESTART-UCEXP).  See output: section below for
example output of needrestart -b.

Use of uninitialized value $ucode_vars{"AVAIL"} in concatenation (.) or string at /usr/sbin/needrestart line 904.

This perl warning disappears when adding the -v option (needrestart -b -v),
and the correct value is reported for NEEDRESTART-UCEXP.


It looks to me like the problem is that line 182 of
/usr/share/perl5/NeedRestart/uCode/AMD.pm ends in a comma (,) instead
of a semicolon (;).  This means that assignment is subsumed into the
next line which is under if ($debug).

See the attached patch.  The debsum error reported below is due to my
applying this patch.

Thanks,
George Robbert



-- Package-specific info:
needrestart -b output:

NEEDRESTART-VER: 3.5
NEEDRESTART-KCUR: 5.10.0-20-amd64
NEEDRESTART-KEXP: 5.10.0-20-amd64
NEEDRESTART-KSTA: 1
NEEDRESTART-UCSTA: 1
NEEDRESTART-UCCUR: 0x03000027
Use of uninitialized value $ucode_vars{"AVAIL"} in concatenation (.) or string at /usr/sbin/needrestart line 904.
NEEDRESTART-UCEXP: 



-- System Information:
Distributor ID:	Devuan
Description:	Devuan GNU/Linux 4 (chimaera)
Release:	4
Codename:	chimaera
Architecture: x86_64

Kernel: Linux 5.10.0-20-amd64 (SMP w/2 CPU threads)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=ANSI_X3.4-1968) (ignored: LC_ALL set to C), LANGUAGE not set
Shell: /bin/sh linked to /usr/bin/dash
Init: sysvinit (via /sbin/init)

Versions of packages needrestart depends on:
ii  binutils                   2.35.2-2
ii  dpkg                       1.20.12
ii  gettext-base               0.21-4
ii  libintl-perl               1.26-3+deb11u1
ii  libmodule-find-perl        0.15-1
ii  libmodule-scandeps-perl    1.30-1
ii  libproc-processtable-perl  0.59-2+b1
ii  libsort-naturally-perl     1.03-2
ii  libterm-readkey-perl       2.38-1+b2
ii  perl                       5.32.1-4+deb11u2
ii  xz-utils                   5.2.5-2.1~deb11u1

Versions of packages needrestart recommends:
ii  libpam-elogind [libpam-systemd]  246.10-2
ii  sysvinit-core                    2.96-7+devuan2

Versions of packages needrestart suggests:
pn  iucode-tool                          <none>
pn  needrestart-session | libnotify-bin  <none>

-- Configuration Files:
/etc/apt/apt.conf.d/99needrestart changed:
DPkg::Post-Invoke {"test -x /usr/lib/needrestart/apt-pinvoke && /usr/lib/needrestart/apt-pinvoke -b || true"; };

/etc/needrestart/hook.d/20-rpm [Errno 2] No such file or directory: '/etc/needrestart/hook.d/20-rpm'

-- no debconf information

-- debsums errors found:
debsums: changed file /usr/share/perl5/NeedRestart/uCode/AMD.pm (from needrestart package)

--===============6328687844274786659==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment; filename="needrestart.patch"

--- /tmp/AMD.pm	2022-12-22 11:00:14.589106185 -0700
+++ /usr/share/perl5/NeedRestart/uCode/AMD.pm	2022-12-22 11:00:24.329046436 -0700
@@ -179,7 +179,7 @@
     if ( exists( $_ucodes->{cpuid}->{$cpuid} ) ) {
         my $prid = $_ucodes->{cpuid}->{$cpuid};
         if ( exists( $_ucodes->{prid}->{$prid} ) ) {
-            $vars{AVAIL} = sprintf( "0x%08x", $_ucodes->{prid}->{$prid} ),
+            $vars{AVAIL} = sprintf( "0x%08x", $_ucodes->{prid}->{$prid} );
 
               print STDERR "$LOGPREF #$info->{processor} found ucode $vars{AVAIL}\n" if ($debug);
             if ( $_ucodes->{prid}->{$prid} > $ucode ) {

--===============6328687844274786659==--

------------=_1674072841-13098-0
Content-Type: message/rfc822
Content-Disposition: inline
Content-Transfer-Encoding: 7bit

Received: (at 731-done) by bugs.devuan.org; 18 Jan 2023 20:12:02 +0000
Return-Path: <[email protected]>
Delivered-To: [email protected]
Received: from email.devuan.org [2001:41d0:2:d06e::5c4:2612]
	by doc.devuan.org with IMAP (fetchmail-6.4.16)
	for <debbugs@localhost> (single-drop); Wed, 18 Jan 2023 20:12:02 +0000 (UTC)
Received: from email.devuan.org
	by email.devuan.org with LMTP
	id QINhMXtSyGPyNwAAmSBk0A
	(envelope-from <[email protected]>)
	for <[email protected]>; Wed, 18 Jan 2023 20:11:39 +0000
Received: by email.devuan.org (Postfix, from userid 109)
	id C1098B85; Wed, 18 Jan 2023 20:11:39 +0000 (UTC)
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on email.devuan.org
X-Spam-Level: 
X-Spam-Status: No, score=0.4 required=5.0 tests=RDNS_DYNAMIC,SPF_PASS
	autolearn=no autolearn_force=no version=3.4.6
Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=193.36.131.86; helo=mx.hindley.org.uk; [email protected]; receiver=<UNKNOWN> 
Received: from mx.hindley.org.uk (193-36-131-86.cfwn.uk [193.36.131.86])
	by email.devuan.org (Postfix) with ESMTPS id 7BB3A226
	for <[email protected]>; Wed, 18 Jan 2023 20:11:39 +0000 (UTC)
Received: from apollo.hindleynet ([192.168.1.3] helo=hindley.org.uk)
	by mx.hindley.org.uk with smtp (Exim 4.84_2)
	(envelope-from <[email protected]>)
	id 1pIEmY-0001Qt-53
	for [email protected]; Wed, 18 Jan 2023 20:11:38 +0000
Received: (nullmailer pid 6481 invoked by uid 1000);
	Wed, 18 Jan 2023 20:11:38 -0000
Date: Wed, 18 Jan 2023 20:11:38 +0000
From: Mark Hindley <[email protected]>
To: [email protected]
Subject: Fixed in Debian #1026927
Message-ID: <[email protected]>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
X-Debbugs-No-Ack: No Thanks

Version: 3.6-1
------------=_1674072841-13098-0--

Message sent:


MIME-Version: 1.0
X-Mailer: MIME-tools 5.509 (Entity 5.509)
X-Loop: [email protected]
From: "Devuan bug Tracking System" <[email protected]>
To: George Robbert <[email protected]>
Subject: bug#731 closed by Mark Hindley <[email protected]> (Fixed in
 Debian #1026927)
Message-ID: <[email protected]>
References: <[email protected]>
 <167174439441.9836.13629055203656959955.reportbug@xecty.minazuki.org>
X-Devuan-PR-Message: they-closed 731
X-Devuan-PR-Package: needrestart
X-Devuan-PR-Keywords: debian
Reply-To: [email protected]
Date: Wed, 18 Jan 2023 20:14:04 +0000
Content-Type: multipart/mixed; boundary="----------=_1674072844-13098-1"

This is a multi-part message in MIME format...

------------=_1674072844-13098-1
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="utf-8"

This is an automatic notification regarding your bug report
which was filed against the needrestart package:

#731: needrestart -b on AMD processors complains of perl uninitialized vari=
able

It has been closed by Mark Hindley <[email protected]>.

Their explanation is attached below along with your original report.
If this explanation is unsatisfactory and you have not received a
better one in a separate message then please contact Mark Hindley <mark@hin=
dley.org.uk> by
replying to this email.


--=20
731: https://bugs.devuan.org/cgi/bugreport.cgi?bug=3D731
Devuan Bug Tracking System
Contact [email protected] with problems

------------=_1674072844-13098-1
Content-Type: message/rfc822
Content-Disposition: inline
Content-Transfer-Encoding: 7bit

Received: (at 731-done) by bugs.devuan.org; 18 Jan 2023 20:12:02 +0000
Return-Path: <[email protected]>
Delivered-To: [email protected]
Received: from email.devuan.org [2001:41d0:2:d06e::5c4:2612]
	by doc.devuan.org with IMAP (fetchmail-6.4.16)
	for <debbugs@localhost> (single-drop); Wed, 18 Jan 2023 20:12:02 +0000 (UTC)
Received: from email.devuan.org
	by email.devuan.org with LMTP
	id QINhMXtSyGPyNwAAmSBk0A
	(envelope-from <[email protected]>)
	for <[email protected]>; Wed, 18 Jan 2023 20:11:39 +0000
Received: by email.devuan.org (Postfix, from userid 109)
	id C1098B85; Wed, 18 Jan 2023 20:11:39 +0000 (UTC)
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on email.devuan.org
X-Spam-Level: 
X-Spam-Status: No, score=0.4 required=5.0 tests=RDNS_DYNAMIC,SPF_PASS
	autolearn=no autolearn_force=no version=3.4.6
Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=193.36.131.86; helo=mx.hindley.org.uk; [email protected]; receiver=<UNKNOWN> 
Received: from mx.hindley.org.uk (193-36-131-86.cfwn.uk [193.36.131.86])
	by email.devuan.org (Postfix) with ESMTPS id 7BB3A226
	for <[email protected]>; Wed, 18 Jan 2023 20:11:39 +0000 (UTC)
Received: from apollo.hindleynet ([192.168.1.3] helo=hindley.org.uk)
	by mx.hindley.org.uk with smtp (Exim 4.84_2)
	(envelope-from <[email protected]>)
	id 1pIEmY-0001Qt-53
	for [email protected]; Wed, 18 Jan 2023 20:11:38 +0000
Received: (nullmailer pid 6481 invoked by uid 1000);
	Wed, 18 Jan 2023 20:11:38 -0000
Date: Wed, 18 Jan 2023 20:11:38 +0000
From: Mark Hindley <[email protected]>
To: [email protected]
Subject: Fixed in Debian #1026927
Message-ID: <[email protected]>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
X-Debbugs-No-Ack: No Thanks

Version: 3.6-1
------------=_1674072844-13098-1
Content-Type: message/rfc822
Content-Disposition: inline
Content-Transfer-Encoding: 7bit

Received: (at submit) by bugs.devuan.org; 22 Dec 2022 21:27:04 +0000
Return-Path: <[email protected]>
Delivered-To: [email protected]
Received: from email.devuan.org [2001:41d0:2:d06e::5c4:2612]
	by doc.devuan.org with IMAP (fetchmail-6.4.16)
	for <debbugs@localhost> (single-drop); Thu, 22 Dec 2022 21:27:04 +0000 (UTC)
Received: from email.devuan.org
	by email.devuan.org with LMTP
	id 1qcCIZTLpGPAFwAAmSBk0A
	(envelope-from <[email protected]>)
	for <[email protected]>; Thu, 22 Dec 2022 21:26:44 +0000
Received: by email.devuan.org (Postfix, from userid 109)
	id 775C7121D; Thu, 22 Dec 2022 21:26:44 +0000 (UTC)
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on email.devuan.org
X-Spam-Level: 
X-Spam-Status: No, score=-0.1 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6
Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=104.200.24.137; helo=yuki.minazuki.org; [email protected]; receiver=<UNKNOWN> 
Received: from yuki.minazuki.org (minazuki.org [104.200.24.137])
	by email.devuan.org (Postfix) with ESMTPS id DE02A226
	for <[email protected]>; Thu, 22 Dec 2022 21:26:39 +0000 (UTC)
Received: from xecty.minazuki.org (localhost [IPv6:::1])
	by yuki.minazuki.org (Postfix) with ESMTP id 90CC4140D8
	for <[email protected]>; Thu, 22 Dec 2022 14:26:34 -0700 (MST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=minazuki.org;
	s=dkim2048; t=1671744394;
	bh=fpLLTs0xlElVR9MuH1MnK37oAIM8j5QTpSHNkln08us=;
	h=From:To:Subject:Date:From;
	b=zZTgGlt4OrhfP0o981wF7SV5kfq30sOhqfU+r9ohbvCAhE70xIpXKV4e4coe4nIXD
	 oZrk8gkXRM3RPWS97v5jozdhub020v34dOftOi9qc3OQL/196RPRIs+l1z3hyMD9+P
	 Vva6Eu8gBpdcWCJZdfSB0AL40Wj+Dan/S1F93nmQqCAHAyM314A1uyXGMD1lvUFmRZ
	 EKZNWzPr1eElklMI8XwxDwdvfJ7tnpzAFT5qM/VVA6YPJ2TFo2ic10n6BF2lh5VI68
	 rJQHNlB6DXmOh2qaSAx4xtlRl/0YKF56+lTY7xvjVyDmGbbHOjyqamPb5X6nx5ddcr
	 Q1NDa4V0/kMXg==
Received: by xecty.minazuki.org (Postfix, from userid 1000)
	id 72D5720195; Thu, 22 Dec 2022 14:26:34 -0700 (MST)
Content-Type: multipart/mixed; boundary="===============6328687844274786659=="
MIME-Version: 1.0
From: George Robbert <[email protected]>
To: Devuan Bug Tracking System <[email protected]>
Subject: needrestart -b on AMD processors complains of perl uninitialized variable
Message-ID: <167174439441.9836.13629055203656959955.reportbug@xecty.minazuki.org>
X-Mailer: reportbug 7.10.3+devuan1
Date: Thu, 22 Dec 2022 14:26:34 -0700

This is a multi-part MIME message sent by reportbug.


--===============6328687844274786659==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

Package: needrestart
Version: 3.5-4+deb11u2
Severity: normal

Dear Maintainer,

When running 'needrestart -b' on an AMD system, I get the following
uninitialized variable warning.  It also does not report the expected
microcode version (NEEDRESTART-UCEXP).  See output: section below for
example output of needrestart -b.

Use of uninitialized value $ucode_vars{"AVAIL"} in concatenation (.) or string at /usr/sbin/needrestart line 904.

This perl warning disappears when adding the -v option (needrestart -b -v),
and the correct value is reported for NEEDRESTART-UCEXP.


It looks to me like the problem is that line 182 of
/usr/share/perl5/NeedRestart/uCode/AMD.pm ends in a comma (,) instead
of a semicolon (;).  This means that assignment is subsumed into the
next line which is under if ($debug).

See the attached patch.  The debsum error reported below is due to my
applying this patch.

Thanks,
George Robbert



-- Package-specific info:
needrestart -b output:

NEEDRESTART-VER: 3.5
NEEDRESTART-KCUR: 5.10.0-20-amd64
NEEDRESTART-KEXP: 5.10.0-20-amd64
NEEDRESTART-KSTA: 1
NEEDRESTART-UCSTA: 1
NEEDRESTART-UCCUR: 0x03000027
Use of uninitialized value $ucode_vars{"AVAIL"} in concatenation (.) or string at /usr/sbin/needrestart line 904.
NEEDRESTART-UCEXP: 



-- System Information:
Distributor ID:	Devuan
Description:	Devuan GNU/Linux 4 (chimaera)
Release:	4
Codename:	chimaera
Architecture: x86_64

Kernel: Linux 5.10.0-20-amd64 (SMP w/2 CPU threads)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=ANSI_X3.4-1968) (ignored: LC_ALL set to C), LANGUAGE not set
Shell: /bin/sh linked to /usr/bin/dash
Init: sysvinit (via /sbin/init)

Versions of packages needrestart depends on:
ii  binutils                   2.35.2-2
ii  dpkg                       1.20.12
ii  gettext-base               0.21-4
ii  libintl-perl               1.26-3+deb11u1
ii  libmodule-find-perl        0.15-1
ii  libmodule-scandeps-perl    1.30-1
ii  libproc-processtable-perl  0.59-2+b1
ii  libsort-naturally-perl     1.03-2
ii  libterm-readkey-perl       2.38-1+b2
ii  perl                       5.32.1-4+deb11u2
ii  xz-utils                   5.2.5-2.1~deb11u1

Versions of packages needrestart recommends:
ii  libpam-elogind [libpam-systemd]  246.10-2
ii  sysvinit-core                    2.96-7+devuan2

Versions of packages needrestart suggests:
pn  iucode-tool                          <none>
pn  needrestart-session | libnotify-bin  <none>

-- Configuration Files:
/etc/apt/apt.conf.d/99needrestart changed:
DPkg::Post-Invoke {"test -x /usr/lib/needrestart/apt-pinvoke && /usr/lib/needrestart/apt-pinvoke -b || true"; };

/etc/needrestart/hook.d/20-rpm [Errno 2] No such file or directory: '/etc/needrestart/hook.d/20-rpm'

-- no debconf information

-- debsums errors found:
debsums: changed file /usr/share/perl5/NeedRestart/uCode/AMD.pm (from needrestart package)

--===============6328687844274786659==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment; filename="needrestart.patch"

--- /tmp/AMD.pm	2022-12-22 11:00:14.589106185 -0700
+++ /usr/share/perl5/NeedRestart/uCode/AMD.pm	2022-12-22 11:00:24.329046436 -0700
@@ -179,7 +179,7 @@
     if ( exists( $_ucodes->{cpuid}->{$cpuid} ) ) {
         my $prid = $_ucodes->{cpuid}->{$cpuid};
         if ( exists( $_ucodes->{prid}->{$prid} ) ) {
-            $vars{AVAIL} = sprintf( "0x%08x", $_ucodes->{prid}->{$prid} ),
+            $vars{AVAIL} = sprintf( "0x%08x", $_ucodes->{prid}->{$prid} );
 
               print STDERR "$LOGPREF #$info->{processor} found ucode $vars{AVAIL}\n" if ($debug);
             if ( $_ucodes->{prid}->{$prid} > $ucode ) {

--===============6328687844274786659==--

------------=_1674072844-13098-1--

Devuan BTS -- Powered by Debian bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.

Devuan Bugs Owner <[email protected]>.
Last modified: Sun, 1 Dec 2024 00:39:02 UTC